From: sashiko-bot@kernel.org
To: "Benjamin Hahn" <B.Hahn@phytec.de>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH 1/5] bindings: Add devicetree bindings for new phyFLEX-i.MX 95 Libra RDK
Date: Fri, 30 Oct 2026 13:37:03 +0000 [thread overview]
Message-ID: <sashiko-outbox-191073@kernel.org> (raw)
In-Reply-To: <20261030-wip-bhahn-imx95_upstreaming-v1-1-1c1cebb5be99@phytec.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: arm: fsl: wrong enum sequence indentation breaks yamllint
--
commit 46ee5c7fdee02b781beb27b96a47fddb125b6299
Author: Benjamin Hahn <B.Hahn@phytec.de>
bindings: Add devicetree bindings for new phyFLEX-i.MX 95 Libra RDK
This commit adds devicetree bindings for the phyFLEX-i.MX 95 Libra RDK board
and the phyFLEX-i.MX 95 FPSC Gamma SoM to fsl.yaml.
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 656f2596e1d53..f917ae7202e96 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1551,6 +1551,13 @@ properties:
> - const: phytec,imx95-phycore-fpsc # phyCORE-i.MX 95 FPSC
> - const: fsl,imx95
>
> + - description: PHYTEC phyFLEX-i.MX95 FPSC-Gamma SoM based boards
> + items:
> + - enum:
> + - phytec,imx95-phyflex-libra-rdk # i.MX 95 phyFLEX Libra RDK
[Severity: Low]
In Documentation/devicetree/bindings/arm/fsl.yaml under
properties.compatible, the sequence entry phytec,imx95-phyflex-libra-rdk
under enum is indented with 12 spaces instead of 14 spaces.
Because Documentation/devicetree/bindings/.yamllint configures the
indentation rule with:
indentation:
spaces: 2
indent-sequences: true
does this cause yamllint and make dt_binding_check to fail with an
indentation error?
Should it be indented by two more spaces to match the surrounding compatible
entries:
- enum:
- phytec,imx95-phyflex-libra-rdk # i.MX 95 phyFLEX Libra RDK
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261030-wip-bhahn-imx95_upstreaming-v1-0-1c1cebb5be99@phytec.de?part=1
next prev parent reply other threads:[~2026-10-30 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 13:32 [PATCH 0/5] dts: update imx95 Libra devicetree for the newest hardware version Benjamin Hahn
2026-10-30 13:32 ` [PATCH 1/5] bindings: Add devicetree bindings for new phyFLEX-i.MX 95 Libra RDK Benjamin Hahn
2026-10-30 13:37 ` sashiko-bot [this message]
2026-10-30 13:55 ` Krzysztof Kozlowski
2026-10-30 13:32 ` [PATCH 2/5] dts: imx95-phyflex-libra-rdk: Add dts for " Benjamin Hahn
2026-10-30 13:56 ` Krzysztof Kozlowski
2026-10-30 14:00 ` sashiko-bot
2026-10-30 13:32 ` [PATCH 3/5] dts: imx95-phyflex-libra-rdk: Add overlays Benjamin Hahn
2026-10-30 13:44 ` sashiko-bot
2026-10-30 13:32 ` [PATCH 4/5] dts: imx95-libra-rdk-fpsc: remove devicetree for old Libra Benjamin Hahn
2026-10-30 13:32 ` [PATCH 5/5] bindings: remove unused binding from old Libra version Benjamin Hahn
2026-10-30 13:47 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-191073@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=B.Hahn@phytec.de \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox