From: sashiko-bot@kernel.org
To: "Jan Remmet" <j.remmet@phytec.de>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: imx8mp-phyboard-pollux: fix i2c3 gpios
Date: Fri, 06 Nov 2026 14:12:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-201547@kernel.org> (raw)
In-Reply-To: <20261106-wip-j-remmet-phytec-de-bspimx8m-4200_pollux_upstreaming-v1-1-aea3a86f3f57@phytec.de>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: imx8mp-phyboard-pollux: missing Fixes trailer for
i2c3 gpios fix
--
commit 996d81256c2ca17742cc01729a7897a22eeec9c7
Author: Yannic Moog <y.moog@phytec.de>
> arm64: dts: imx8mp-phyboard-pollux: fix i2c3 gpios
>
> sda-gpios and scl-gpios were swapped.
> scl is GPIO5 18 and sda is GPIO5 19. Assign the correct GPIOs.
>
> Signed-off-by: Yannic Moog <y.moog@phytec.de>
> Signed-off-by: Jan Remmet <j.remmet@phytec.de>
[Severity: Low]
Since this fixes the swapped I2C3 recovery GPIO assignments introduced when
i2c3 was enabled, should the commit message include a Fixes tag?
Fixes: 18c783cf09aa ("arm64: dts: imx8mp-phyboard-pollux: Enable i2c3")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-wip-j-remmet-phytec-de-bspimx8m-4200_pollux_upstreaming-v1-0-aea3a86f3f57@phytec.de?part=1
next prev parent reply other threads:[~2026-11-06 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 14:08 [PATCH 0/2] arm64: dts: imx8mp-phyboard-pollux: updates Jan Remmet
2026-11-06 14:08 ` [PATCH 1/2] arm64: dts: imx8mp-phyboard-pollux: fix i2c3 gpios Jan Remmet
2026-11-06 14:12 ` sashiko-bot [this message]
2026-11-06 14:08 ` [PATCH 2/2] arm64: dts: imx8mp-phyboard-pollux: update gpio-line-names Jan Remmet
2026-11-11 20:55 ` [PATCH 0/2] arm64: dts: imx8mp-phyboard-pollux: updates Frank.Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-201547@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=j.remmet@phytec.de \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox