From: sashiko-bot@kernel.org
To: "Roland Hieber" <rhi@pengutronix.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT..."
<imx@lists.linux.dev>
Cc: robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v2] arm64: dts: imx8mp-skov: fix input supply properties
Date: Mon, 16 Nov 2026 15:07:12 +0000 [thread overview]
Message-ID: <sashiko-outbox-217223@kernel.org> (raw)
In-Reply-To: <20261116145823.3018840-1-rhi@pengutronix.de>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: imx8mp-skov: missing Fixes trailer on PMIC supply
fix
--
commit dab9e66c18c2737f269617a98e59a193266cb200
Author: Roland Hieber <rhi@pengutronix.de>
> arm64: dts: imx8mp-skov: fix input supply properties
>
> The nxp,pca9450c node used the non-standard 'vin-supply' binding until now.
> Upstream commit 4c33cef58965eb655a0a ("regulator: pca9450: link regulator
> inputs to supply groups") added support for 'in*-supply' bindings, so move
> to this standardized binding to fix errors on boot:
>
> nxp-pca9450 0-0025: Failed to create device link (0x180) with supplier
> regulator-5v-p for
> /soc@0/bus@30800000/i2c@30a20000/pmic@25/regulators/LDO1
>
> Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
[Severity: Low]
Since this fixes invalid per-regulator vin-supply properties and boot-time
device link errors, should this include a Fixes tag (with 4c33cef58965
("regulator: pca9450: link regulator inputs to supply groups") as a
prerequisite):
Fixes: 6d382d51d979 ("arm64: dts: freescale: Add SKOV IMX8MP CPU revB board")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116145823.3018840-1-rhi@pengutronix.de?part=1
prev parent reply other threads:[~2026-11-16 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 14:42 [PATCH v2] arm64: dts: imx8mp-skov: fix input supply properties Roland Hieber
2026-11-16 15:07 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217223@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=rhi@pengutronix.de \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox