From: sashiko-bot@kernel.org
To: "Stefano Radaelli" <stefano.radaelli21@gmail.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev
Cc: robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v1 1/1] arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations
Date: Wed, 18 Nov 2026 17:09:49 +0000 [thread overview]
Message-ID: <sashiko-outbox-221580@kernel.org> (raw)
In-Reply-To: <20261118165719.46297-1-stefano.r@variscite.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: freescale: stale cm33 and mu1 nodes left in
imx93-var-dart.dtsi
--
commit eb85dd95d900da2ad181972f70b093ede806d6a0
Author: Stefano Radaelli <stefano.r@variscite.com>
arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations
This commit adds Cortex-M33 device tree overlays and combined DTBs for
Variscite DART-MX93 on Sonata and VAR-SOM-MX93 on Symphony, sharing common
remoteproc and mailbox nodes via imx93-var-common-m33.dtsi.
> diff --git a/arch/arm64/boot/dts/freescale/imx93-var-common-m33.dtsi b/arch/arm64/boot/dts/freescale/imx93-var-common-m33.dtsi
> new file mode 100644
> index 0000000000000..51b4cfe143d47
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx93-var-common-m33.dtsi
> @@ -0,0 +1,24 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Common Cortex-M33 configuration for Variscite i.MX93 modules
> + *
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com/
> + *
> + */
> +
> +/* Use the reserved memory and resource table address from the carrier DTS. */
> +&cm33 {
> + mbox-names = "tx", "rx", "rxdb";
> + mboxes = <&mu1 0 1
> + &mu1 1 1
> + &mu1 3 1>;
> + memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>,
> + <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>;
> + memory-region-names = "vdev0buffer", "vdev0vring0", "vdev0vring1",
> + "vdev1vring0", "vdev1vring1", "rsc-table";
> + status = "okay";
> +};
> +
> +&mu1 {
> + status = "okay";
> +};
[Severity: Medium]
Should the existing cm33 and mu1 nodes be removed from imx93-var-dart.dtsi now
that M33 support is moved into imx93-var-common-m33.dtsi and the -m33 overlay?
Unlike imx93-var-som.dtsi, imx93-var-dart.dtsi still enables cm33 and mu1:
arch/arm64/boot/dts/freescale/imx93-var-dart.dtsi:
&cm33 {
mbox-names = "tx", "rx", "rxdb";
mboxes = <&mu1 0 1>,
<&mu1 1 1>,
<&mu1 3 1>;
memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>,
<&vdev1vring0>, <&vdev1vring1>, <&rsc_table>;
status = "okay";
};
...
&mu1 {
status = "okay";
};
As a result, booting the base imx93-var-dart-sonata.dtb without the -m33
overlay still enables cm33 and mu1 while leaving all M33-reserved peripherals
enabled for Linux. In addition, because that node lacks memory-region-names
and imx93-var-dart-sonata.dts names the DMA pool node vdevbuffer@87f00000,
imx_rproc_prepare() does not match strstarts(res.name, "vdev0buffer") and maps
the virtio DMA pool as a carveout.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118165719.46297-1-stefano.r@variscite.com?part=1
prev parent reply other threads:[~2026-11-18 17:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 16:57 [PATCH v1 1/1] arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations Stefano Radaelli
2026-11-18 17:09 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-221580@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox