Linux kernel and device drivers for NXP i.MX platforms
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Freimut Diener" <f.diener@pengutronix.de>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
	conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH 3/5] arm64: dts: freescale: imx93-11x11-frdm: use 8-bit eMMC bus
Date: Fri, 20 Nov 2026 09:43:47 +0000	[thread overview]
Message-ID: <sashiko-outbox-224871@kernel.org> (raw)
In-Reply-To: <20261120-imx93-frdm-fixes-v1-3-78dde22a56fe@pengutronix.de>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: freescale: imx93-11x11-frdm sets 8-bit bus-width
  on 4-bit usdhc3
--

commit 1b60016bb1be48a6e2b6b1dfc5d19ef5de2490d6
Author: Freimut Diener <f.diener@pengutronix.de>

arm64: dts: freescale: imx93-11x11-frdm: use 8-bit eMMC bus

This commit changes the bus-width property of the usdhc3 node in
imx93-11x11-frdm.dts from 4 to 8.

> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts
> index fbe3543e1ee8c..af674f3f48364 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts
> @@ -75,7 +75,7 @@ &sai1 {
>  };
>  
>  &usdhc3 {
> -	bus-width = <4>;
> +	bus-width = <8>;
>  	keep-power-in-suspend;
>  	mmc-pwrseq = <&usdhc3_pwrseq>;
>  	non-removable;

[Severity: Medium]
Should usdhc3 really have an 8-bit bus width here?

On the FRDM-i.MX93, the 8-bit eMMC is connected to usdhc1, which already
has bus-width = <8> in
arch/arm64/boot/dts/freescale/imx93-11x11-frdm-common.dtsi.  usdhc3
(428b0000.mmc) is connected to the 4-bit Wi-Fi SDIO interface of the
IW612 module, and both pinctrl_usdhc3 and the i.MX93 SoC itself
(arch/arm64/boot/dts/freescale/imx93-pinfunc.h) only have four data lines
(USDHC3_DATA0 through USDHC3_DATA3).

428b0000.mmc logs the HS400 warning in mmc_validate_host_caps() because
usdhc3 is missing the no-mmc property (unlike usdhc2 in
imx93-11x11-frdm-common.dtsi).  Keeping bus-width = <4> and adding no-mmc
(and no-sd) on usdhc3 would match the hardware and avoid the warning.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-imx93-frdm-fixes-v1-0-78dde22a56fe@pengutronix.de?part=3

  reply	other threads:[~2026-11-20  9:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  9:37 [PATCH 0/5] arm64: dts: freescale: Fix i.MX93 FRDM hardware descriptions Freimut Diener
2026-11-20  9:37 ` [PATCH 1/5] arm64: dts: freescale: imx93-11x11-frdm: Enable I2C level shifter Freimut Diener
2026-11-20 10:08   ` Joseph Guo (OSS)
2026-11-20  9:37 ` [PATCH 2/5] arm64: dts: freescale: imx93-11x11-frdm-common: Describe PCAL6524 supply Freimut Diener
2026-11-20  9:37 ` [PATCH 3/5] arm64: dts: freescale: imx93-11x11-frdm: use 8-bit eMMC bus Freimut Diener
2026-11-20  9:43   ` sashiko-bot [this message]
2026-11-20  9:50   ` Joseph Guo (OSS)
2026-11-20 10:14     ` Freimut Diener
2026-11-20  9:37 ` [PATCH 4/5] arm64: dts: freescale: imx91-93-common: Add EL2 virtual timer interrupt Freimut Diener
2026-11-20  9:37 ` [PATCH 5/5] arm64: dts: freescale: imx93-11x11-frdm-common: Describe USB2 VBUS supply Freimut Diener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224871@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=f.diener@pengutronix.de \
    --cc=imx@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox