mkinitrd unification across distributions
 help / color / mirror / Atom feed
From: Victor Lowther <victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Amadeusz Żołnowski" <aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] dracut-functions: find_rule a bit smarter
Date: Mon, 05 Jul 2010 09:53:57 -0500	[thread overview]
Message-ID: <1278341637.4056.17.camel@localhost.localdomain> (raw)
In-Reply-To: <20100705112407.26026f40@etiriah>

On Mon, 2010-07-05 at 11:24 +0200, Amadeusz Żołnowski wrote:
> Matches rules filename if it's specified without prefix number.
> ---
>  dracut-functions |   25 +++++++++++++++++++++++--
>  1 files changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/dracut-functions b/dracut-functions
> index be6b2e9..1f2528e 100755
> --- a/dracut-functions
> +++ b/dracut-functions
> @@ -319,11 +319,32 @@ inst_symlink() {
>      inst "$realsrc" && ln -s "$realsrc" "$target"
>  }
>  
> -# find a udev rule in the usual places.
> +# find a udev rule in the usual places and try to be smart (just a bit).
> +# See example:
> +#   find_rule default.rules
> +#   find_rule 50-default.rules
> +# All of them will return: /lib/udev/rules.d/50-udev-default.rules
> +# If there are few matching files, error message is printed.
>  find_rule() {
> +    local rule t
> +
>      [[ -f $1 ]] && { echo "$1"; return 0; }
>      for r in . /lib/udev/rules.d /etc/udev/rules.d $dracutbasedir/rules.d; do
# Parsing the output of ls can lead to strange and subtle bugs.
# Use globbing and parameter expansion instead, and go with the first
# matching file.
	local f
	for f in "$r/$1" "$r/${1%%-*}-udev-%{1##*-}" "$r/"*"$1"; do
		[[ -f $f ]] || continue
		echo "$f"
		return 0
>      done
>      return 1
>  }

-- 
Victor Lowther
LPIC2 UCP RHCE 

  reply	other threads:[~2010-07-05 14:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-05  7:06 [PATCH 1/3] dracut: info which module is sourced; updated dracut usage Amadeusz Żołnowski
2010-07-05  7:08 ` [PATCH 2/3] dracut-functions: info which udev rules are skipped Amadeusz Żołnowski
2010-07-05  7:12   ` [PATCH 3/3] dracut-functions: find_rule a bit smarter Amadeusz Żołnowski
2010-07-05  9:24     ` Amadeusz Żołnowski
2010-07-05 14:53       ` Victor Lowther [this message]
     [not found]         ` <1278341637.4056.17.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-07-07  9:19           ` Amadeusz Żołnowski
2010-07-07 10:27             ` [PATCH] dracut-functions: find_rule a bit smarter; thanks to V. Lowther Amadeusz Żołnowski
2010-07-09 13:48   ` [PATCH 2/3] dracut-functions: info which udev rules are skipped Harald Hoyer
2010-07-09 13:47 ` [PATCH 1/3] dracut: info which module is sourced; updated dracut usage Harald Hoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278341637.4056.17.camel@localhost.localdomain \
    --to=victor.lowther-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox