Re: [PATCH] 90crypt: keys on external devices support

["Amadeusz Żołnowski" <aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

This thread is becoming huuuge. :-)


Excerpts from Mr Dash Four's message of Thu Oct 21 17:48:03 +0200 2010:
> My point still stands though - leaving the 'guessing' of the target file 
> system to mount is not a good idea and <key_dev_fs> should not be 
> removed as a parameter (it may not be mandatory, but should always be 
> catered for).

File system is mounted read-only, so even on wrong guess nothing bad may
happen.  I think Karel has made good point about <key_dev_fs> parameter.

But if you need to insist on having it, we might introduce following
syntax:

  rd.luks.key=<key_path>[:<key_dev>[:<luks_dev>]]

Unfolding <key_dev> in BNF:

  <key_dev> ::= "UUID=" <uuid> | "LABEL=" <label> | <path_part>
  <path_part> ::= "FS=" <fs> "=" <path> | <path>

Where <path> matches following regular expression:

  ^/dev/.*

Hope everything's clear and that will satisfy you. :-)

Karel, what do you think about it?


> I would also add that both <key_dev> and <luks_dev> should be able to
> support the Linux drive notation (sdXX, hdXX etc) in addition to label
> and uuid.

It does already with my latest not yet merged patch.  Hope to work on it
this weekend to be merged on Monday.
--
Amadeusz Żołnowski

PGP key fpr: C700 CEDE 0C18 212E 49DA  4653 F013 4531 E1DB FAB5

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]