Re: [PATCH 2/3] 90crypt: probe for keydev asynchronously; changed kernel arg

["Amadeusz Żołnowski" <aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1928 bytes --]

Excerpts from Andrey Borzenkov's message of Mon Nov 15 17:50:50 +0100 2010:
> 2010/11/15 Amadeusz Żołnowski <aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>:
> > Excerpts from Andrey Borzenkov's message of Sat Nov 13 09:50:54 +0100 2010:
> >> 2010/11/12 Amadeusz Żołnowski <aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>:
> >> [...]
> >> > diff --git a/modules.d/90crypt/cryptroot-ask.sh b/modules.d/90crypt/cryptroot-ask.sh
> >> [...]
> >> >  inst "$moddir"/cryptroot-ask.sh /sbin/cryptroot-ask
> >>
> >> As you are currently working on it, could you look into making
> >> cryptroot coexist with plymouth? Currently they fight for
> >> /sbin/cryptroot-ask; I thought about adding minimal plugin support
> >> (i.e. something like /cryptroot-ask.d where modules can drop their
> >> implementation; they will be tried is sequence until some succeeds).
> >> Then /sbin/cryptroot-ask could be moved to base and be simple wrapper
> >> around this directory.
> >>
> >> Unfortunately I do not currently have ready-to-use infrastructure to
> >> test this implementation.
> >
> > OK.  Thanks for reporting that.  Matt Smith has already merged
> > cryptroot-ask from plymouth to crypt module and it worked well until
> > that my new patch.  I'll try to fix the problem.
> 
> Actually I missed this patch, sorry. I'm still not sure how it behaves
> if plymouth binary is available but plymouthd itself is not active/not
> showing splash.

Just look at the commit 7254c24a76d5f5afe4168d513a00756dc85cb460.

Even with my new patch splash shows up.  The problem which appears with
my patch is that when you do rdbreak, boot process terminates as it
should, drops to shell and… console hangs (the last is the "feature"
which appears with keydev; I'll investigate on it as soon as will have
some time).
--
Amadeusz Żołnowski

PGP key fpr: C700 CEDE 0C18 212E 49DA  4653 F013 4531 E1DB FAB5

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]