public inbox for initramfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn-l3A5Bk7waGM@public.gmane.org>
To: harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	trenn-l3A5Bk7waGM@public.gmane.org,
	Hannes Reinecke <hare-l3A5Bk7waGM@public.gmane.org>
Subject: [PATCH 14/42] Implement 'rd.timeout' to modify the device timeout
Date: Thu, 11 Dec 2014 15:46:05 +0100	[thread overview]
Message-ID: <1418309193-11208-15-git-send-email-trenn@suse.de> (raw)
In-Reply-To: <1418309193-11208-1-git-send-email-trenn-l3A5Bk7waGM@public.gmane.org>

From: Hannes Reinecke <hare-l3A5Bk7waGM@public.gmane.org>

When generating units for devices the administrator might
want to use a different timeout than the default.
So implement a new parameter 'rd.timeout' for this.

References: bnc#878770

Signed-off-by: Hannes Reinecke <hare-l3A5Bk7waGM@public.gmane.org>
Signed-off-by: Thomas Renninger <trenn-l3A5Bk7waGM@public.gmane.org>
---
 dracut.cmdline.7.asc                    | 7 ++++++-
 modules.d/98systemd/rootfs-generator.sh | 7 +++++--
 modules.d/99base/dracut-lib.sh          | 6 +++++-
 3 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/dracut.cmdline.7.asc b/dracut.cmdline.7.asc
index 8e4835d..5ff84ef 100644
--- a/dracut.cmdline.7.asc
+++ b/dracut.cmdline.7.asc
@@ -142,11 +142,16 @@ Misc
     have been loaded. This parameter can be specified multiple times.
 
 **rd.retry=**__<seconds>__::
-    specify how long dracut should wait for devices to appear.
+    specify how long dracut should retry the initqueue to configure devices.
     The default is 30 seconds. After 2/3 of the time, degraded raids are force
     started. If you have hardware, which takes a very long time to announce its
     drives, you might want to extend this value.
 
+**rd.timeout=**__<seconds>__::
+    specify how long dracut should wait for devices to appear. The
+    default is '0', which means 'forever'. Note that this timeout
+    should be longer than rd.retry to allow for proper configuration.
+
 **rd.noverifyssl**::
     accept self-signed certificates for ssl downloads.
 
diff --git a/modules.d/98systemd/rootfs-generator.sh b/modules.d/98systemd/rootfs-generator.sh
index 9523729..5b06137 100755
--- a/modules.d/98systemd/rootfs-generator.sh
+++ b/modules.d/98systemd/rootfs-generator.sh
@@ -5,8 +5,11 @@ type getarg >/dev/null 2>&1 || . /lib/dracut-lib.sh
 generator_wait_for_dev()
 {
     local _name
+    local _timeout
 
     _name="$(str_replace "$1" '/' '\x2f')"
+    _timeout=$(getarg rd.timeout)
+    _timeout=${_timeout:-0}
 
     [ -e "$hookdir/initqueue/finished/devexists-${_name}.sh" ] && return 0
 
@@ -27,7 +30,7 @@ generator_wait_for_dev()
         mkdir -p /run/systemd/generator/${_name}.device.d
         {
             echo "[Unit]"
-            echo "JobTimeoutSec=0"
+            echo "JobTimeoutSec=$_timeout"
         } > /run/systemd/generator/${_name}.device.d/timeout.conf
     fi
 }
@@ -58,6 +61,6 @@ case "$root" in
         rootok=1 ;;
 esac
 
-[ "${root%%:*}" = "block" ] && generator_wait_for_dev "${root#block:}"
+[ "${root%%:*}" = "block" ] && generator_wait_for_dev "${root#block:}" "$RDRETRY"
 
 exit 0
diff --git a/modules.d/99base/dracut-lib.sh b/modules.d/99base/dracut-lib.sh
index 5fc5615..f7cffc4 100755
--- a/modules.d/99base/dracut-lib.sh
+++ b/modules.d/99base/dracut-lib.sh
@@ -890,12 +890,16 @@ wait_for_dev()
     local _name
     local _needreload
     local _noreload
+    local _timeout
 
     if [ "$1" = "-n" ]; then
         _noreload=1
         shift
     fi
 
+    _timeout=$(getarg rd.timeout)
+    _timeout=${_timeout:-0}
+
     _name="$(str_replace "$1" '/' '\x2f')"
 
     type mark_hostonly >/dev/null 2>&1 && mark_hostonly "$hookdir/initqueue/finished/devexists-${_name}.sh"
@@ -922,7 +926,7 @@ wait_for_dev()
             mkdir -p ${PREFIX}/etc/systemd/system/${_name}.device.d
             {
                 echo "[Unit]"
-                echo "JobTimeoutSec=0"
+                echo "JobTimeoutSec=$_timeout"
             } > ${PREFIX}/etc/systemd/system/${_name}.device.d/timeout.conf
             type mark_hostonly >/dev/null 2>&1 && mark_hostonly /etc/systemd/system/${_name}.device.d/timeout.conf
             _needreload=1
-- 
1.8.5.2

  parent reply	other threads:[~2014-12-11 14:46 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11 14:45 [RESEND] SUSE patches which should show up mainline Thomas Renninger
     [not found] ` <1418309193-11208-1-git-send-email-trenn-l3A5Bk7waGM@public.gmane.org>
2014-12-11 14:45   ` [PATCH 01/42] mkinitrd-suse: Update to sles12 SUSE state Thomas Renninger
2014-12-11 14:45   ` [PATCH 02/42] systemd always tries to load autofs4 Thomas Renninger
2014-12-11 14:45   ` [PATCH 03/42] Fixup mdraid setup Thomas Renninger
2014-12-11 14:45   ` [PATCH 04/42] 95udev-rules: Include correct sg3_utils rules Thomas Renninger
     [not found]     ` <1418309193-11208-5-git-send-email-trenn-l3A5Bk7waGM@public.gmane.org>
2014-12-17 10:00       ` Harald Hoyer
2014-12-11 14:45   ` [PATCH 05/42] 90multipath: install correct multipath rules Thomas Renninger
2014-12-11 14:45   ` [PATCH 06/42] 95iscsi: Autodetect iSCSI firmware Thomas Renninger
2014-12-11 14:45   ` [PATCH 07/42] 95iscsi: Install libgcc_s library Thomas Renninger
2014-12-11 14:45   ` [PATCH 08/42] 95iscsi: Set correct iscsi_started value for iSCSI firmware Thomas Renninger
2014-12-11 14:46   ` [PATCH 09/42] 95iscsi: strip one set of quotes when calling initqueue Thomas Renninger
2014-12-11 14:46   ` [PATCH 10/42] 95iscsi: Fixup bnx2i offload booting Thomas Renninger
2014-12-11 14:46   ` [PATCH 11/42] 95iscsi: More empty cmdline fixes Thomas Renninger
2014-12-11 14:46   ` [PATCH 12/42] 95iscsi: generate commandline for software iscsi Thomas Renninger
2014-12-11 14:46   ` [PATCH 13/42] iscsi: iscsi.initiator and others can and must only show up once Thomas Renninger
2014-12-11 14:46   ` Thomas Renninger [this message]
2014-12-11 14:46   ` [PATCH 15/42] Do not call 'lvm' for non-LVM device-mapper devices Thomas Renninger
2014-12-11 14:46   ` [PATCH 16/42] Print stored dracut commandline during initramfs build Thomas Renninger
2014-12-11 14:46   ` [PATCH 17/42] Align dev_unit_name() with systemd's function Thomas Renninger
     [not found]     ` <1418309193-11208-18-git-send-email-trenn-l3A5Bk7waGM@public.gmane.org>
2015-02-24  9:37       ` Alexander Tsoy
2014-12-11 14:46   ` [PATCH 18/42] Generate fallback mount unit for root filesystem Thomas Renninger
2014-12-11 14:46   ` [PATCH 19/42] 99base: warn on invalid command for initqueue Thomas Renninger
2014-12-11 14:46   ` [PATCH 20/42] Handle module alias properly Thomas Renninger
2014-12-11 14:46   ` [PATCH 21/42] 99base: Increase initqueue timeout in non systemd case Thomas Renninger
2014-12-11 14:46   ` [PATCH 22/42] 90lvm: Install dm-snapshot module Thomas Renninger
2014-12-11 14:46   ` [PATCH 23/42] Check for logfile (--logfile option) and create it if necessary Thomas Renninger
2014-12-11 14:46   ` [PATCH 24/42] dracut.sh: Avoid duplicate devices in host_devs Thomas Renninger
2014-12-11 14:46   ` [PATCH 25/42] dracut.sh: Fix UUID= fstab parsing in case --mount option is passed Thomas Renninger
2014-12-11 14:46   ` [PATCH 26/42] dracut.usage.asc: Remove distro specific help from manpage Thomas Renninger
2014-12-11 14:46   ` [PATCH 27/42] nfs: Add ip=... and root=nfs... parameters to internal dracut Thomas Renninger
2014-12-11 14:46   ` [PATCH 28/42] 95iscsi: parse output from iscsiadm correctly Thomas Renninger
2014-12-11 14:46   ` [PATCH 29/42] dracut: Do not stop installing drivers if one fails Thomas Renninger
2014-12-11 14:46   ` [PATCH 30/42] 95fcoe: update fcoe interface check Thomas Renninger
2014-12-11 14:46   ` [PATCH 31/42] 95fcoe: Store current configuration in dracut cmdline Thomas Renninger
     [not found]     ` <1418309193-11208-32-git-send-email-trenn-l3A5Bk7waGM@public.gmane.org>
2014-12-12  3:02       ` Baoquan He
     [not found]         ` <20141212030201.GD1678-je1gSBvt1Tcx0jIIkfS+Ph/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-12-12 14:05           ` Hannes Reinecke
2014-12-11 14:46   ` [PATCH 32/42] 95fcoe: skip VLAN devices in fcoe-up Thomas Renninger
2014-12-11 14:46   ` [PATCH 33/42] 95fcoe: start lldpad separately Thomas Renninger
2014-12-11 14:46   ` [PATCH 34/42] Enhance suse.conf and debug module example with SUSE-specific settings Thomas Renninger
2014-12-11 14:46   ` [PATCH 35/42] 40network: add missing _arch variable declaration Thomas Renninger
2014-12-11 14:46   ` [PATCH 36/42] 99base: Add chown binary Thomas Renninger
2014-12-11 14:46   ` [PATCH 37/42] 90kernel-modules: install scsi_dh_alua Thomas Renninger
2014-12-11 14:46   ` [PATCH 38/42] Fix non-export of journal dev boot options Thomas Renninger
2014-12-11 14:46   ` [PATCH 39/42] Also export root= boot param for hostonly-cmdline case Thomas Renninger
2014-12-11 14:46   ` [PATCH 40/42] Don't create lots of empty cmdline files " Thomas Renninger
2014-12-11 14:46   ` [PATCH 41/42] 95rootfs-block: Correctly terminate commandline parameter Thomas Renninger
     [not found]     ` <1418309193-11208-42-git-send-email-trenn-l3A5Bk7waGM@public.gmane.org>
2014-12-17 10:44       ` Harald Hoyer
     [not found]         ` <54915E9C.2050306-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-12-17 10:57           ` Hannes Reinecke
     [not found]             ` <54916198.1060206-l3A5Bk7waGM@public.gmane.org>
2014-12-17 12:21               ` Harald Hoyer
2014-12-11 14:46   ` [PATCH 42/42] dracut: nbd: Only complain of missing binary in hostonly mode if Thomas Renninger
2014-12-17 10:26   ` [RESEND] SUSE patches which should show up mainline Harald Hoyer
     [not found]     ` <54915A3C.9050409-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-12-17 11:34       ` Thomas Renninger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418309193-11208-15-git-send-email-trenn@suse.de \
    --to=trenn-l3a5bk7wagm@public.gmane.org \
    --cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hare-l3A5Bk7waGM@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox