mkinitrd unification across distributions
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Patch v2 1/2] 99fs-lib/fs-lib.sh: Let user specify the action after fail for fsck
Date: Thu, 30 May 2013 13:02:40 -0400	[thread overview]
Message-ID: <20130530170240.GH2864@redhat.com> (raw)
In-Reply-To: <078c160e62c2c750efe71fc8a05dd7c5de71bde3.1369816679.git.bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Wed, May 29, 2013 at 04:38:31PM +0800, Baoquan He wrote:
> The fsck is ignored when replace emergency_shell with action_on_fail,
> now add it.

should action_on_fail be named rd.action_on_fail to make it explicit that
this is an initramfs option and not a kernel command line option as such.

Vivek

> 
> Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  modules.d/99fs-lib/fs-lib.sh |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules.d/99fs-lib/fs-lib.sh b/modules.d/99fs-lib/fs-lib.sh
> index e1f3074..88e7348 100755
> --- a/modules.d/99fs-lib/fs-lib.sh
> +++ b/modules.d/99fs-lib/fs-lib.sh
> @@ -7,14 +7,14 @@ type getarg >/dev/null 2>&1 || . /lib/dracut-lib.sh
>  fsck_ask_reboot() {
>      info "note - fsck suggests reboot, if you"
>      info "leave shell, booting will continue normally"
> -    emergency_shell -n "(reboot ?)"
> +    action_on_fail -n "(reboot ?)"
>  }
>  
>  fsck_ask_err() {
>      warn "*** An error occurred during the file system check."
>      warn "*** Dropping you to a shell; the system will try"
>      warn "*** to mount the filesystem(s), when you leave the shell."
> -    emergency_shell -n "(Repair filesystem)"
> +    action_on_fail -n "(Repair filesystem)"
>  }
>  
>  # inherits: _ret _drv _out
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-05-30 17:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29  8:38 [Patch v2 1/2] 99fs-lib/fs-lib.sh: Let user specify the action after fail for fsck Baoquan He
     [not found] ` <078c160e62c2c750efe71fc8a05dd7c5de71bde3.1369816679.git.bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-29  8:38   ` [Patch v2 2/2] let user specify action after systemd start dracut-emergency Baoquan He
     [not found]     ` <dc98d3640cb7f265d9a84a11b87e494635485e8d.1369816679.git.bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-30  8:50       ` Baoquan
     [not found]         ` <51A712D0.80002-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-30  9:15           ` Harald Hoyer
     [not found]             ` <51A718C8.9070406-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-30 10:15               ` Baoquan
     [not found]                 ` <51A726D0.9070509-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-30 10:33                   ` Harald Hoyer
     [not found]                     ` <51A72AF4.6070700-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-31  7:16                       ` Baoquan
     [not found]                         ` <51A84E34.5060906-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-31  7:25                           ` Harald Hoyer
2013-05-31  9:39               ` Baoquan
     [not found]                 ` <51A86FDC.1050606-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-31  9:45                   ` Harald Hoyer
     [not found]                     ` <51A87129.4070307-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-03  3:04                       ` Baoquan
     [not found]                         ` <51AC07B2.1010407-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-07-01 13:51                           ` Baoquan
2013-05-30 17:02   ` Vivek Goyal [this message]
     [not found]     ` <20130530170240.GH2864-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-31  7:30       ` [Patch v2 1/2] 99fs-lib/fs-lib.sh: Let user specify the action after fail for fsck Harald Hoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130530170240.GH2864@redhat.com \
    --to=vgoyal-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox