public inbox for initramfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: "Cristian Rodríguez" <crrodriguez@opensuse.org>
Cc: "initramfs@vger.kernel.org" <initramfs@vger.kernel.org>,
	systemd-devel@lists.freedesktop.org
Subject: Re: Second (erroneous) check of rootfs?
Date: Thu, 8 Jan 2015 09:18:10 +0300	[thread overview]
Message-ID: <20150108091810.500d510f@opensuse.site> (raw)
In-Reply-To: <54ADEA1F.3080908@opensuse.org>

В Wed, 07 Jan 2015 23:23:27 -0300
Cristian Rodríguez <crrodriguez@opensuse.org> пишет:

> El 07/01/15 a las 22:55, Nikolai Zhubr escribió:
> > 08.01.2015 4:12, Cristian Rodríguez:
> >> El 07/01/15 a las 21:43, Lennart Poettering escribió:
> >>
> >>> Maybe suse forgot to include this service file in the initrd or so?
> >>
> >> Correct. It appears to be a bug in the dracut package. I wonder why ..
> >
> > Ok. So should I file a report to opensuse bugtracker? I have no idea if
> > the issue is suse-specific actually... Although I know that dracut is
> > very new for suse, that might explain it...
> 
> Hrmm.. looking at the dracut upstream sources.. this service is not 
> included in the required file list. so it is an upstream problem.
> 
> Attached is a patch to fix the problem.
> 
> 

Are you sure? Where this service is called in initrd then? Note that
fsck for root *did* run. dracut runs generator for root in
98systemd/rootfs-generator.sh which does

            echo "RequiresOverridable=systemd-fsck@${_name}.service"
            echo "After=systemd-fsck@${_name}.service"

And initrd cannot use systemd-fsck-root.service because this service
assumes current root is "/" which is of course wrong in initrd. 

So options are

a) somehow dynamically disable systemd-fsck-root.service from within
initrd 
b) pretend systemd-fsck-root.service did run. Which probably is the
same as it means overriding service definition
c) allow passing real root device to systemd-fsck-root.service. Very
ugly hack is

[Service]
ExecStart=@rootlibexecdir@/systemd-fsck $__REAL_ROOT_DEVICE__

where __REAL_ROOT_DEVICE__ is added by drop-in in initrd, by
rootfs-generator.sh

[Service]
Environment=__REAL_ROOT_DEVICE__=${_name}"
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

  reply	other threads:[~2015-01-08  6:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <54ADD119.2050906@yandex.ru>
     [not found] ` <20150108004352.GA22800@gardel-login>
     [not found]   ` <54ADD98D.9080608@opensuse.org>
     [not found]     ` <54ADE3A1.6060107@yandex.ru>
     [not found]       ` <54ADE3A1.6060107-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org>
2015-01-08  2:23         ` [systemd-devel] Second (erroneous) check of rootfs? Cristian Rodríguez
2015-01-08  6:18           ` Andrei Borzenkov [this message]
     [not found]             ` <54AEA37D.8040008@gmail.com>
     [not found]               ` <20150108155548.GA23263@gardel-login>
     [not found]                 ` <54AEAC69.9050801@gmail.com>
     [not found]                   ` <20150108203046.6cb52b01@opensuse.site>
     [not found]                     ` <54AEE948.4060308@gmail.com>
     [not found]                       ` <54AFA59C.2040301@yandex.ru>
     [not found]                         ` <CAPWNY8X2X=V2u46fLgvARDbiFws9VkgJVevpFs54FdnsgGcNVg@mail.gmail.com>
     [not found]                           ` <CAJCQCtTpHAozdGuNXP2bSfB=+ooVLPHa0Bd0BjqU6J7eT2Wn1A@mail.gmail.com>
     [not found]                             ` <54B12E5C.2060408@yandex.ru>
     [not found]                               ` <20150111100908.75945b61@opensuse.site>
     [not found]                                 ` <54B253D6.9040306@yandex.ru>
     [not found]                                   ` <54B253D6.9040306-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org>
2015-01-11 11:11                                     ` Andrei Borzenkov
     [not found]                                       ` <20150111141125.2d2c1f38-stAJ6ESoqRzYCGPCin2YbQ@public.gmane.org>
2015-01-11 11:15                                         ` Chris Murphy
     [not found]                                           ` <CAJCQCtS1tGwp4iELnNp8R3gHY=uS+HFnk_J7k_CUxNX3Ga6upQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-11 11:57                                             ` Andrei Borzenkov
2015-01-11 12:09                                               ` Chris Murphy
2015-01-21 13:09                                               ` Harald Hoyer
     [not found]                                       ` <54B26B1E.30900@yandex.ru>
2015-01-11 12:54                                         ` Andrei Borzenkov
2015-01-11 14:07                                           ` Nikolai Zhubr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150108091810.500d510f@opensuse.site \
    --to=arvidjaar@gmail.com \
    --cc=crrodriguez@opensuse.org \
    --cc=initramfs@vger.kernel.org \
    --cc=systemd-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox