Re: [PATCH 2/4] 40network: Fix race condition when wait for networks

[Pawel Wieczorkiewicz <pwieczorkiewicz-l3A5Bk7waGM@public.gmane.org>]

On Tue, 02 Jun 2015 12:15:26 +0200
Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:

> > +            echo "[ -f /tmp/net.*.did-setup ]"
> > >$hookdir/initqueue/finished/wait-network.sh
> 
> err, if multiple networks are up, [ -f /tmp/net.*.did-setup ] is not
> correct shell syntax.
> 
> $ [ -e /dev/* ] && echo OK
> bash: [: too many arguments
> 

Can this condition really occur?
Shouldn't we be done with the wait-network initqueue job condition just
after 1st network is setup (the '*' here just means whatever interface
is up, not multiple interfaces)?

AFAIR each network ifup request is a separate initqueue job and the
condition is evaluated between jobs switches. So first
created /tmp/net.*.did-setup, whatever interface it has, makes this
condition be satisfied.

This way or another, it can be improved to the longer and more
demanding multifiles variant (for file in /tmp/net.*.did-setup loop or
set -- /tmp/net.*.did-setup and $# > 0 evaluation).

-- 
Best Regards,
Pawel Wieczorkiewicz <pwieczorkiewicz-l3A5Bk7waGM@public.gmane.org>, Linux System Developer

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu,
Graham Norton, HRB 21284 (AG Nürnberg) Maxfeldstraße 5 / 90409
Nürnberg / Germany / Phone: +49-911-740 53 - 613