From: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] dracut-functions.sh: move early mkdir code to dracut.sh
Date: Tue, 30 Jun 2015 09:53:32 +0800 [thread overview]
Message-ID: <20150630015332.GA9752@localhost.localdomain> (raw)
In-Reply-To: <20150625020802.GA20085-0VdLhd/A9PkMZ+PoPUf8/x/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
On 06/25/15 at 10:08am, Dave Young wrote:
> Move early mkdir code to dracut.sh so that dracut-fuctions.sh can
> be used by other components.
>
> For example Fedora kdump mkdumprd uses several functions which were
> copied from dracut-functions.sh, with this patch applied dracut-functions.sh
> contains only functions so that we can remove the duplicate code in kdump.
>
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> dracut-functions.sh | 11 -----------
> dracut.sh | 11 +++++++++++
> 2 files changed, 11 insertions(+), 11 deletions(-)
>
> Index: dracut/dracut-functions.sh
> ===================================================================
> --- dracut.orig/dracut-functions.sh
> +++ dracut/dracut-functions.sh
> @@ -19,17 +19,6 @@
> #
> export LC_MESSAGES=C
>
> -if [[ $DRACUT_KERNEL_LAZY ]] && ! [[ $DRACUT_KERNEL_LAZY_HASHDIR ]]; then
> - if ! [[ -d "$initdir/.kernelmodseen" ]]; then
> - mkdir -p "$initdir/.kernelmodseen"
> - fi
> - DRACUT_KERNEL_LAZY_HASHDIR="$initdir/.kernelmodseen"
> -fi
> -
> -if [[ $initdir ]] && ! [[ -d $initdir ]]; then
> - mkdir -p "$initdir"
> -fi
> -
self NACK, will repost and export DRACUT_KERNEL_LAZY_HASHDIR earlier
Also I need reuse push/pop functions in multipath module so I will repost
another patch series later.
Thanks
Dave
prev parent reply other threads:[~2015-06-30 1:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 2:08 [PATCH] dracut-functions.sh: move early mkdir code to dracut.sh Dave Young
[not found] ` <20150625020802.GA20085-0VdLhd/A9PkMZ+PoPUf8/x/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2015-06-30 1:53 ` Dave Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630015332.GA9752@localhost.localdomain \
--to=dyoung-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox