From: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
To: Ard Biesheuvel <ardb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Arvind Sankar <nivedita-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
Cc: Sergey Shatunov <me-fHUSW+XspFU@public.gmane.org>,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-efi <linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Donovan Tremura
<neurognostic-g/b1ySJe57IkP3XJZ0H8fw@public.gmane.org>,
Harald Hoyer <harald-PnQE6hpDOpmlVyrhU4qvOw@public.gmane.org>
Subject: Re: [PATCH 1/2] x86/boot/compressed/64: Remove .bss/.pgtable from bzImage
Date: Mon, 6 Apr 2020 19:21:02 +0200 [thread overview]
Message-ID: <20200406172102.GF2520@zn.tnic> (raw)
In-Reply-To: <CAMj1kXG+34-bK1XuxX5VopkRt1SV1ewUAEmif+aQj5cJQ=9vbA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Mon, Apr 06, 2020 at 03:29:18PM +0200, Ard Biesheuvel wrote:
> > What do you think of the other problem -- that's actually worse to fix,
> > as it won't just be when kaslr is disabled, the startup_64 code will do
> > relocation to the end of init_size and clobber the initrd before getting
> > to the kaslr code, so it will break as soon as the firmware loads the
> > "unified kernel image" at a 2Mb-aligned address. The only thing I can
> > think of is to just unconditionally call efi_relocate_kernel if we were
> > entered via handover_entry?
> >
>
> Yes, that seems to be the most robust approach.
The commit in question is this one:
d5cdf4cfeac9 ("efi/x86: Don't relocate the kernel unless necessary")
I presume?
I'm guessing it can simply be reverted as it doesn't fix a bug but it is
just an optimization... provided I'm not missing something, of course.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2020-04-06 17:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200109150218.16544-1-nivedita@alum.mit.edu>
[not found] ` <20200405154245.11972-1-me@prok.pw>
[not found] ` <20200405231845.GA3095309@rani.riverdale.lan>
[not found] ` <c692eea9213172d8ef937322b02ff585b0dfea82.camel@prok.pw>
[not found] ` <c692eea9213172d8ef937322b02ff585b0dfea82.camel-fHUSW+XspFU@public.gmane.org>
2020-04-06 3:51 ` [PATCH 1/2] x86/boot/compressed/64: Remove .bss/.pgtable from bzImage Arvind Sankar
2020-04-06 7:32 ` Ard Biesheuvel
2020-04-06 8:47 ` Borislav Petkov
[not found] ` <20200406084738.GA2520-Jj63ApZU6fQ@public.gmane.org>
2020-04-06 9:11 ` Ard Biesheuvel
[not found] ` <CAMj1kXHAieZDvPKfjF=J+G=QVS+=XS-b4RP_=mjCEFEB_E_+Qw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-04-06 11:20 ` Borislav Petkov
2020-04-06 13:22 ` Arvind Sankar
[not found] ` <20200406132215.GA113388-ZaHV2fEG+eCZQHugZx4kin66tl449arB@public.gmane.org>
2020-04-06 13:29 ` Ard Biesheuvel
[not found] ` <CAMj1kXG+34-bK1XuxX5VopkRt1SV1ewUAEmif+aQj5cJQ=9vbA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-04-06 16:01 ` Arvind Sankar
[not found] ` <20200406160148.GB113388-ZaHV2fEG+eCZQHugZx4kin66tl449arB@public.gmane.org>
2020-04-06 16:22 ` Ard Biesheuvel
[not found] ` <CAMj1kXFKDWB9n0kWhXHLH0XP0O1v_0b=bFJad=kBvx2qVxqDcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-04-06 16:52 ` Arvind Sankar
2020-04-06 16:59 ` Ard Biesheuvel
[not found] ` <CAMj1kXEUkJ1XJ9OTsijeq8tNNYC00bXqEV44OMtX5ugo9WoLKA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-04-06 18:06 ` [PATCH 1/2] efi/x86: Move efi stub globals from .bss to .data Arvind Sankar
2020-04-06 18:06 ` [PATCH 2/2] efi/x86: Always relocate the kernel for EFI handover entry Arvind Sankar
[not found] ` <20200406180614.429454-1-nivedita-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2020-04-06 18:29 ` [PATCH 1/2] efi/x86: Move efi stub globals from .bss to .data Ard Biesheuvel
2020-04-08 7:43 ` Dave Young
[not found] ` <20200408074334.GA21886-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2020-04-08 7:49 ` Ard Biesheuvel
2020-04-09 14:39 ` Arvind Sankar
2020-04-09 14:47 ` Ard Biesheuvel
[not found] ` <CAMj1kXEm=E6B+kjZktG=sBPLQ=_HFfUz6KFLskNGzRnuMjn0gA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-04-09 16:35 ` Arvind Sankar
[not found] ` <20200409163530.GA785575-ZaHV2fEG+eCZQHugZx4kin66tl449arB@public.gmane.org>
2020-04-10 14:47 ` Arvind Sankar
2020-04-10 15:26 ` Ard Biesheuvel
[not found] ` <CAMj1kXHMQgnmdoA+qKLGa=gYg4J2p-DU3-K1LiM=AT61pi+Fvw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-04-14 14:57 ` Daniel Kiper
2020-04-10 11:26 ` Thomas Meyer
2020-04-10 14:38 ` Arvind Sankar
2020-04-11 8:50 ` Thomas Meyer
2020-04-06 17:21 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406172102.GF2520@zn.tnic \
--to=bp-gina5biwoiwzqb+pc5nmwq@public.gmane.org \
--cc=ardb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=harald-PnQE6hpDOpmlVyrhU4qvOw@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=me-fHUSW+XspFU@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=neurognostic-g/b1ySJe57IkP3XJZ0H8fw@public.gmane.org \
--cc=nivedita-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox