Re: [PATCH 19/33] Restore original IFS value

Thomas Renninger
2014-11-21T10:53:38Z

On Friday, November 21, 2014 10:10:54 AM Harald Hoyer wrote:
> On 20.11.2014 15:56, Thomas Renninger wrote:
> > From: Hannes Reinecke <hare-l3A5Bk7waGM@public.gmane.org>
..
> > diff --git a/modules.d/95iscsi/module-setup.sh
> > b/modules.d/95iscsi/module-setup.sh index 9975e59..f551c49 100755
> > --- a/modules.d/95iscsi/module-setup.sh
> > +++ b/modules.d/95iscsi/module-setup.sh
> > @@ -29,16 +29,18 @@ check() {
> >
> > }
> >
> > get_ibft_mod() {
> >
> > - local ibft_mac=$1
> > + local ibft_mac=$1 IFS
> >
...
> > done
> >
> > }
>
> That's a valid point.

Wait, this function is touched in a later patch, nuking
IFS modifcations totally.
I removed the whole patch and adjusted the later patch now.
Which, eh..., is missing.
I had not the whole series applied when sending.
Patches 34..42 are missing.
I'll resend. No need to go through all. It's just the
ones in the end which are new.
New series will have your 2 mentioned fixes added already.

I also add the fcoe patches, will take the one or other hour...

Thanks,

Thomas