From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pingfan Liu Subject: Re: [PATCH] modules.d: introduce ssh-server module to provide service Date: Wed, 21 Jun 2017 22:13:33 -0400 (EDT) Message-ID: <345083888.25426436.1498097613534.JavaMail.zimbra@redhat.com> References: <1495593594-26460-1-git-send-email-piliu@redhat.com> <7871761b-2b6a-edd6-da43-35c17bebcd92@suse.de> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 05DC8B814F In-Reply-To: <7871761b-2b6a-edd6-da43-35c17bebcd92-l3A5Bk7waGM@public.gmane.org> Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Daniel Molkentin Cc: Harald Hoyer , Liu ping fan , initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org ----- Original Message ----- > From: "Daniel Molkentin" > To: "Harald Hoyer" , "Liu ping fan" , "Pingfan Liu" > Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Sent: Wednesday, June 21, 2017 11:14:21 PM > Subject: Re: [PATCH] modules.d: introduce ssh-server module to provide service > > On 06/21/2017 04:41 PM, Harald Hoyer wrote: > > On 12.06.2017 07:47, Liu ping fan wrote: > >> Hi Harald, what is your opinion of such functionality? > > yeah, nice, but some issues: > > > > 1) "inst" should be used instead of "inst_simple" for executables and *.so > > 2) That is a long hardcoded list of dependencies. Are they all needed? > > 3) The module should probably be renamed to rhel-7-ssh-server or a similar > > name > > to reflect, that it is most likely only working on this distribution > > variant > > 4) Does it have to be shipped in upstream dracut? Looks like this can live > > totally > > fine in a project, which lives outside of dracut. > I was about to introduce something similar, I would try to keep it > general purpose. A good use case could be to unlock an encrypted root fs > after a reboot, even though that would require more work. > Yeah, I notice that project. It is great, but it is a pity that it is not merged into drauct upstream since it is a little complicated and difficult to maintain. > Some things I noticed: > > 1. This should go into modules.d, not the root > 2. check() should return 255 even if sshd is found (you probably don't > want this to be the default)? > 3. the multiple inst_simples for the different keys seem excessive, plus > there might be more than those. Use a glob? > Yes. Thank you for advice. Best regards, Pingfan > Cheers, > Daniel > > -- > To unsubscribe from this list: send the line "unsubscribe initramfs" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >