From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Warren Togami <wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs <initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: 90kernel-modules-loaded must be --hostonly
Date: Fri, 29 May 2009 09:26:16 +0200 [thread overview]
Message-ID: <4A1F8E18.2030400@redhat.com> (raw)
In-Reply-To: <4A1F6B12.5050001-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 05/29/2009 06:56 AM, Warren Togami wrote:
> On 05/28/2009 02:26 PM, Warren Togami wrote:
>>> /sbin/lsmod | while read mod rest; do
>>> instmods "$mod"
>>> done
>>
>> This part relies on looking at the running system, and thus must not be
>> part of the default dracut run. This seems OK for --hostonly mode.
>>
>> Changing this will likely break some users depending on modules not
>> otherwise pulled in elsewhere? Should I just go ahead and see what
>> breaks?
>
> Oh, I now notice that the check script skips this entirely unless you
> are in hostonly mode. This is the reason why I'm not getting the KMS
> drivers loaded prior to plymouth (although plymouth itself is still
> busted for other reasons.)
>
> [ "$1" != "-h" ] && exit 1
>
> But is this correct? It seems we should be checking the hostonly
> variable and not if "-h" happens to be the first parameter.
>
> -h isn't -H.
> -h isn't --hostonly
This obviously broke by introducing the --help option.. just fix it.
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-05-29 7:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 18:26 90kernel-modules-loaded must be --hostonly Warren Togami
[not found] ` <4A1ED743.3010107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-29 4:56 ` Warren Togami
[not found] ` <4A1F6B12.5050001-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-29 7:26 ` Harald Hoyer [this message]
[not found] ` <4A1F8E18.2030400-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-29 7:44 ` Harald Hoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1F8E18.2030400@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox