mkinitrd unification across distributions
 help / color / mirror / Atom feed
From: Seewer Philippe <philippe.seewer-omB+W0Dpw2o@public.gmane.org>
To: David Dillow <dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 4/5] Add DAD do dhclient-script
Date: Wed, 24 Jun 2009 21:56:03 +0200	[thread overview]
Message-ID: <4A4284D3.5050007@bfh.ch> (raw)
In-Reply-To: <1245868789.31775.16.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>

David Dillow wrote:
> On Wed, 2009-06-24 at 20:08 +0200, Philippe Seewer wrote:
>> The manpage for dhclient-script says:
>>
>> Before actually configuring the address, dhclient-script should
>> somehow ARP for it and exit with a nonzero status if it receives a
>> reply.
>>
>> By using arping in dracut this is very easy, since arping has a
>> specific option to do just that.
> 
>> --- a/modules.d/40network/dhclient-script
>> +++ b/modules.d/40network/dhclient-script
>> @@ -64,6 +64,7 @@ case $reason in
>>  	sleep 1
>>  	;;
>>      BOUND)
>> +	arping -q -D -c 2 -I $netif $new_ip_address || exit 1
> 
> Where's the addition of arping to 40network/install?

*sigh* Thanks for noticing, forgot to add it to the commit. Complete
Patch below

---
 modules.d/40network/dhclient-script |    1 +
 modules.d/40network/install         |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/modules.d/40network/dhclient-script b/modules.d/40network/dhclient-script
index 6df630d..3fb8da6 100755
--- a/modules.d/40network/dhclient-script
+++ b/modules.d/40network/dhclient-script
@@ -64,6 +64,7 @@ case $reason in
 	sleep 1
 	;;
     BOUND)
+	arping -q -D -c 2 -I $netif $new_ip_address || exit 1
 	setup_interface 
 	set | while read line; do
 	    [ "${line#new_}" = "$line" ] && continue
diff --git a/modules.d/40network/install b/modules.d/40network/install
index 0b76cbd..513503c 100755
--- a/modules.d/40network/install
+++ b/modules.d/40network/install
@@ -1,5 +1,5 @@
 #!/bin/bash
-dracut_install ip dhclient hostname
+dracut_install ip dhclient hostname arping
 # Include wired net drivers, excluding wireless
 for modname in $(find "/lib/modules/$kernel/kernel/drivers" -name '*.ko'); do
   if nm -uPA $modname | grep -q eth_type_trans; then
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-06-24 19:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24 18:08 [PATCH 0/5] Netroot updates and multinic test-suite Philippe Seewer
     [not found] ` <1245866912-3643-1-git-send-email-philippe.seewer-omB+W0Dpw2o@public.gmane.org>
2009-06-24 18:08   ` [PATCH 1/5] Bugfix: Fix BOOTIF argument translation Philippe Seewer
2009-06-24 18:08   ` [PATCH 2/5] Give the kernel some time to up interfaces Philippe Seewer
     [not found]     ` <1245866912-3643-3-git-send-email-philippe.seewer-omB+W0Dpw2o@public.gmane.org>
2009-06-26  3:02       ` David Dillow
     [not found]         ` <1245985355.30948.14.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2009-06-26  7:07           ` Seewer Philippe
2009-06-24 18:08   ` [PATCH 3/5] Be a bit more optimistic when setting mtus Philippe Seewer
2009-06-24 18:08   ` [PATCH 4/5] Add DAD do dhclient-script Philippe Seewer
     [not found]     ` <1245866912-3643-5-git-send-email-philippe.seewer-omB+W0Dpw2o@public.gmane.org>
2009-06-24 18:39       ` David Dillow
     [not found]         ` <1245868789.31775.16.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
2009-06-24 19:56           ` Seewer Philippe [this message]
     [not found]             ` <4A4284D3.5050007-omB+W0Dpw2o@public.gmane.org>
2009-06-26  2:45               ` David Dillow
2009-06-24 18:08   ` [PATCH 5/5] Add multinic test suite Philippe Seewer
     [not found]     ` <1245866912-3643-6-git-send-email-philippe.seewer-omB+W0Dpw2o@public.gmane.org>
2009-06-26  2:56       ` David Dillow
     [not found]         ` <1245985005.30948.11.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2009-06-26  6:43           ` Seewer Philippe
2009-06-26  3:20   ` [PATCH 0/5] Netroot updates and multinic test-suite David Dillow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A4284D3.5050007@bfh.ch \
    --to=philippe.seewer-omb+w0dpw2o@public.gmane.org \
    --cc=dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox