From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH 1/4] Use glob for libdir when installing multipath libraries. Date: Wed, 25 Nov 2009 11:21:37 +0100 Message-ID: <4B0D0531.2050401@redhat.com> References: <1259092378-14143-1-git-send-email-pjones@redhat.com> <4B0C40BC.5000107@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4B0C40BC.5000107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: initramfs Cc: Peter Jones Hi, On 11/24/2009 09:23 PM, Peter Jones wrote: > Use "/lib*/" not "/lib/" so it works when they're in /lib/multipath as > well as when they're in /lib64/multipath > --- > modules.d/90multipath/install | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/modules.d/90multipath/install b/modules.d/90multipath/install > index 9552918..d20ea38 100755 > --- a/modules.d/90multipath/install > +++ b/modules.d/90multipath/install > @@ -11,8 +11,9 @@ for f in \ > /sbin/xdrgetuid \ > /sbin/xdrgetprio \ > /etc/xdrdevices.conf \ > - /lib/libmultipath* \ > - /lib/multipath/* ;do > + /lib*/libmultipath* \ > + /lib*/multipath/* > + ;do > inst $f > done > Not sure if we want to handle this this way, this way if both a 32 bit and 64 bit version are present on a system both will get copied to the initrd, I think it would be better to handle this how it is handled in for example: modules/01fips/install or modules/95nfs/install: if ldd $(which rpc.idmapd) |grep -q lib64; then LIBDIR="/lib64" else LIBDIR="/lib" fi dracut_install $(ls {/usr,}$LIBDIR/libnfsidmap_nsswitch.so* 2>/dev/null ) Regards, Hans