mkinitrd unification across distributions
 help / color / mirror / Atom feed
From: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/4] Use glob for libdir when installing multipath libraries.
Date: Wed, 25 Nov 2009 10:52:20 -0500	[thread overview]
Message-ID: <4B0D52B4.5090501@redhat.com> (raw)
In-Reply-To: <1259162752-22372-2-git-send-email-pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On 11/25/2009 10:25 AM, Peter Jones wrote:
> Use "/lib*/" not "/lib/" so it works when they're in /lib/multipath as
> well as when they're in /lib64/multipath
> ---
>  modules.d/90multipath/install |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/modules.d/90multipath/install b/modules.d/90multipath/install
> index 9552918..4890825 100755
> --- a/modules.d/90multipath/install
> +++ b/modules.d/90multipath/install
> @@ -2,6 +2,12 @@ if [[ $hostonly ]]; then
>      inst /etc/multipath.conf
>  fi
>  
> +if ldd $(/sbin/multipath) |grep -q lib64; then

This is obviously wrong.

> +    LIBDIR="/lib64"
> +else
> +    LIBDIR="/lib"
> +fi
> +
>  for f in  \
>      /sbin/dmsetup \
>      /sbin/kpartx \
> @@ -11,8 +17,8 @@ for f in  \
>      /sbin/xdrgetuid \
>      /sbin/xdrgetprio \
>      /etc/xdrdevices.conf \
> -    /lib/libmultipath*  \
> -    /lib/multipath/* ;do 
> +    $(ls $LIBDIR/libmultipath* $LIBDIR/multipath/*) \
> +    	;do
>      inst $f
>  done
>  


-- 
        Peter

"I can imagine a world without war, without hate. I can imagine us
attacking it, because they'd never expect it."

  parent reply	other threads:[~2009-11-25 15:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24 19:52 Add support for bringing up multipath root devices Peter Jones
     [not found] ` <1259092378-14143-1-git-send-email-pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-24 19:52   ` [PATCH 1/4] Use glob for libdir when installing multipath libraries Peter Jones
     [not found]     ` <1259092378-14143-2-git-send-email-pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-24 19:55       ` Peter Jones
     [not found]         ` <4B0C3A19.3010509-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-24 19:59           ` Peter Jones
2009-11-24 19:52   ` [PATCH 2/4] Add #!/bin/bash for consistency Peter Jones
2009-11-24 19:52   ` [PATCH 3/4] Make sure and get all the multipath related modules Peter Jones
2009-11-24 19:52   ` [PATCH 4/4] Bring up multipath devices that are configured in multipath.conf Peter Jones
     [not found] ` <4B0C40BC.5000107@redhat.com>
     [not found]   ` <4B0C40BC.5000107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 10:21     ` [PATCH 1/4] Use glob for libdir when installing multipath libraries Hans de Goede
     [not found]       ` <4B0D0531.2050401-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:10         ` Peter Jones
     [not found] ` <4B0C40E4.6080006@redhat.com>
     [not found]   ` <4B0C40E4.6080006-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 10:22     ` [PATCH 2/4] Add #!/bin/bash for consistency Hans de Goede
     [not found] ` <4B0C40C7.7010206@redhat.com>
     [not found]   ` <4B0C40C7.7010206-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 10:23     ` [PATCH 3/4] Make sure and get all the multipath related modules Hans de Goede
     [not found] ` <4B0C40ED.9000909@redhat.com>
     [not found]   ` <4B0C40ED.9000909-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 10:35     ` [PATCH 4/4] Bring up multipath devices that are configured in multipath.conf Hans de Goede
     [not found]       ` <4B0D087E.1030502-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:17         ` Peter Jones
     [not found]           ` <4B0D4A9F.1090606-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:25             ` Add support for bringing up multipath root devices [version 2] Peter Jones
2009-11-25 15:25             ` [PATCH 1/4] Use glob for libdir when installing multipath libraries Peter Jones
     [not found]               ` <1259162752-22372-2-git-send-email-pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:52                 ` Peter Jones [this message]
2009-11-25 15:25             ` [PATCH 2/4] Add #!/bin/bash for consistency Peter Jones
2009-11-25 15:25             ` [PATCH 3/4] Make sure and get all the multipath related modules Peter Jones
2009-11-25 15:25             ` [PATCH 4/4] Bring up multipath devices that are configured in multipath.conf Peter Jones
     [not found]               ` <1259162752-22372-5-git-send-email-pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:53                 ` Hans de Goede
     [not found]                   ` <4B0D5306.8050706-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:52                     ` Peter Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0D52B4.5090501@redhat.com \
    --to=pjones-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox