Re: [PATCH] add readonly overlay support for dmsquash

[Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On 03/04/2010 03:16 PM, Karel Zak wrote:
> On Thu, Mar 04, 2010 at 02:07:49PM +0100, Harald Hoyer wrote:
>> On 02/26/2010 09:23 PM, Karel Zak wrote:
>>> On Fri, Feb 26, 2010 at 09:44:29AM -0500, Joey Boggs wrote:
>>>>        # set up the snapshot
>>>> -    echo 0 `blockdev --getsize $BASE_LOOPDEV` snapshot $BASE_LOOPDEV $OVERLAY_LOOPDEV p 8 | dmsetup create live-rw
>>>> +    echo 0 `blockdev --getsize $BASE_LOOPDEV` snapshot $BASE_LOOPDEV $OVERLAY_LOOPDEV p 8 | dmsetup create $readonly_overlay live-rw
>>>                  ^^^^^^^^^^^^^^^^^
>>>
>>>    Don't use --getsize, this option is deprecated and it's based
>>>    on BLKGETSIZE ioctl that returns *32-bit* sector count (= 2TiB only).
>>>
>>>    Please, use --getsz. For more details see blockdev(8) man page.
>     ^^^^^^^^^^^^^^^^^^^^^
>>>
>>>       Karel
>>>
>>
>> patched to use --getsize64
>
>   That's wrong solution. The --getsize64 option returns size in bytes,
>   but you need size in 512-byte sectors. Use --getsz, read "man
>   blockdev" ;-)
>
>      Karel
>

doh :) stupid me