mkinitrd unification across distributions
 help / color / mirror / Atom feed
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Amadeusz Żołnowski" <aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] dracut: setup English locales for Dracut build script
Date: Fri, 18 Jun 2010 18:56:24 +0200	[thread overview]
Message-ID: <4C1BA538.7010304@redhat.com> (raw)
In-Reply-To: <20100618133841.61845f0d-YdJE6FOikKfe60hTmSeVGxfX6IwIUJvj@public.gmane.org>

On 06/18/2010 01:38 PM, Amadeusz Żołnowski wrote:
> Dracut rely upon programs' output like ldd's "not a dynamic executable".
> Assume user sets up Polish locales and then ldd prints
> "nie jest dynamicznym programem wykonywalnym".  The patch prevents this.
> ---
>   dracut |   15 +++++++++++++++
>   1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/dracut b/dracut
> index 3be4989..1437625 100755
> --- a/dracut
> +++ b/dracut
> @@ -71,6 +71,17 @@ Creates initial ramdisk images for preloading modules
>   "
>   }
>
> +# Change locales and language leaving existing suffix (.utf8 or similar).
> +# $1 = language (e.g. en_US)
> +change_locales() {
> +    local lang=(${LANG/./ })
> +    lang[0]=$1
> +    lang=${lang[@]}
> +    LANG=${lang/ /.}
> +    LC_ALL=${LANG}
> +    export LANG LC_ALL
> +}
> +
>   while (($#>  0)); do
>       case $1 in
>   	-f|--force) force=yes;;
> @@ -107,6 +118,10 @@ done
>
>   PATH=/sbin:/bin:/usr/sbin:/usr/bin
>   export PATH
> +# We rely upon programs' output like ldd's "not found", so we have to
> +# set up English locales.
> +change_locales en_US
> +
>
>   [[ $debug ]]&&  {
>       export PS4='${BASH_SOURCE}@${LINENO}(${FUNCNAME[0]}): ';

Hmm, we probably should prefix every call to an app, where we parse the output 
with LANG=C like this:

LANG=C ldd $file | grep -q "not found"

  parent reply	other threads:[~2010-06-18 16:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-18 11:38 [PATCH] dracut: setup English locales for Dracut build script Amadeusz Żołnowski
     [not found] ` <20100618133841.61845f0d-YdJE6FOikKfe60hTmSeVGxfX6IwIUJvj@public.gmane.org>
2010-06-18 12:16   ` Victor Lowther
     [not found]     ` <AANLkTil85GmgtdZieaCwu93axSYZnlpVDpMX2kSRQiUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-18 13:30       ` Amadeusz Żołnowski
2010-06-18 13:28   ` Adam Spragg
     [not found]     ` <201006181428.09276.adam-2iSS7ArDF14@public.gmane.org>
2010-06-19 11:25       ` Amadeusz Żołnowski
2010-06-18 16:56   ` Harald Hoyer [this message]
     [not found]     ` <4C1BA538.7010304-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-22  9:23       ` Harald Hoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1BA538.7010304@redhat.com \
    --to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox