From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Michal Soltys <soltys-R61QfzASbfY@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] parse-lvm.sh: fix for generated initqueue/finished script
Date: Fri, 12 Aug 2011 08:07:31 +0200 [thread overview]
Message-ID: <4E44C323.2040001@redhat.com> (raw)
In-Reply-To: <1311856810-2481-1-git-send-email-soltys-R61QfzASbfY@public.gmane.org>
On 28.07.2011 14:40, Michal Soltys wrote:
> The script that was generated always returned the status of the last test
> condition, potentially missing any earlier non-existing devices.
>
> The change assures, that the script returns 0 only if all expected
> devices are found.
>
> Signed-off-by: Michal Soltys <soltys-R61QfzASbfY@public.gmane.org>
> ---
> modules.d/90lvm/parse-lvm.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/modules.d/90lvm/parse-lvm.sh b/modules.d/90lvm/parse-lvm.sh
> index 2e21d82..b85a1ac 100755
> --- a/modules.d/90lvm/parse-lvm.sh
> +++ b/modules.d/90lvm/parse-lvm.sh
> @@ -10,7 +10,7 @@ if ! getargbool 1 rd.lvm -n rd_NO_LVM; then
> rm -f /etc/udev/rules.d/64-lvm*.rules
> else
> for dev in $(getargs rd.lvm.vg rd_LVM_VG=) $(getargs rd.lvm.lv rd_LVM_LV=); do
> - printf '[ -e "/dev/%s" ]\n' $dev \
> + printf '[ -e "/dev/%s" ] || return 1\n' $dev \
> >> $hookdir/initqueue/finished/lvm.sh
> {
> printf '[ -e "/dev/%s" ] || ' $dev
pushed
prev parent reply other threads:[~2011-08-12 6:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 12:40 [PATCH] parse-lvm.sh: fix for generated initqueue/finished script Michal Soltys
[not found] ` <1311856810-2481-1-git-send-email-soltys-R61QfzASbfY@public.gmane.org>
2011-08-12 6:07 ` Harald Hoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E44C323.2040001@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=soltys-R61QfzASbfY@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox