From: Harald Hoyer <harald.hoyer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Will Woods <wwoods-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] make livenet module optional
Date: Fri, 21 Oct 2011 13:16:45 +0200 [thread overview]
Message-ID: <4EA1549D.50104@gmail.com> (raw)
In-Reply-To: <1319133444-27980-2-git-send-email-wwoods-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 20.10.2011 19:57, Will Woods wrote:
> The livenet module was intended to be optional, so its check() function
> in module-setup.sh should return 255, not 0.
>
> This was causing systems without 'wget' to fail to build initramfs, as
> in RHBZ#747632.
> ---
> modules.d/90livenet/module-setup.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/modules.d/90livenet/module-setup.sh b/modules.d/90livenet/module-setup.sh
> index 3ee7521..613a225 100755
> --- a/modules.d/90livenet/module-setup.sh
> +++ b/modules.d/90livenet/module-setup.sh
> @@ -5,7 +5,7 @@ check() {
> # a live, host-only image doesn't really make a lot of sense
> [[ $hostonly ]] && return 1
> command -v wget || return 1
> - return 0
> + return 255
> }
>
> depends() {
already fixed, thanks!
next prev parent reply other threads:[~2011-10-21 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 17:57 [PATCH 1/2] apply-live-updates.sh: copy without glob Will Woods
[not found] ` <1319133444-27980-1-git-send-email-wwoods-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-10-20 17:57 ` [PATCH 2/2] make livenet module optional Will Woods
[not found] ` <1319133444-27980-2-git-send-email-wwoods-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-10-21 11:16 ` Harald Hoyer [this message]
2011-10-21 11:18 ` [PATCH 1/2] apply-live-updates.sh: copy without glob Harald Hoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA1549D.50104@gmail.com \
--to=harald.hoyer-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wwoods-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox