From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Subject: Re: [PATCH 4/4 branch usrmove] Add ssh client module code Date: Mon, 26 Dec 2011 10:22:34 +0800 Message-ID: <4EF7DA6A.30809@redhat.com> References: <20111223080430.GA12670@darkstar.nay.redhat.com> <4EF7D604.9080500@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4EF7D604.9080500-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Cong Wang Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 12/26/2011 10:03 AM, Dave Young wrote: > On 12/25/2011 07:57 PM, Cong Wang wrote: > >> On Fri, 23 Dec 2011 at 08:04 GMT, Dave Young wrote: >>> Add ssh-client module, which support ssh key mode and interactive mode. >>> with --sshkey option you can provide the ssh key to be installed >>> >>> Usage: >>> 1. sshkey mode: >>> transfer your public key to remote machine with ssh-copy-id or do it mannaully >>> example of options: >>> ./dracut -l -H -a ssh-client --sshkey /root/.ssh/id_rsa i.img >>> 2. interactive mode: >>> need use --ctty option, ie.: >>> ./dracut -l -H -a ssh-client --ctty i.img >> >> Seems --sshkey and --ctty are only for ssh-client module, >> so, what if the user specifies -sshkey or --ctty but doesn't >> use ssh-client module? > > > Thanks for review. > --sshkey is for ssh module only, I have added param info in doc. --ctty > is not only for ssh, it can be used by other stuff. if use use --sshkey > but do not add ssh-client module it will just have one more global > variable sshkey, it will not add more file to initrd. > > As for the param, the ideal way is create generic way to add dracut > module param like something below: > ./dracut -a ssh-client,sshkey=xyz > > Another way is use kernel param like rd.sshkey=xyz, but I do not like > this way. Oops, kernel param is only usefull for runtime option of initrd, ignore above line. > > So currently generic module param will need more effort also will > influence all dracut modules, I think just add --sshkey is acceptable. > >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe initramfs" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- Thanks Dave