From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Subject: Re: [PATCH 2/4 branch usrmove] Add job control support to emergency shell Date: Mon, 26 Dec 2011 12:56:20 +0800 Message-ID: <4EF7FE74.8090500@redhat.com> References: <20111223080423.GA12666@darkstar.nay.redhat.com> <4EF7D69A.4010800@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Cong Wang Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 12/26/2011 12:51 PM, Cong Wang wrote: > On Mon, Dec 26, 2011 at 10:06 AM, Dave Young wrote: >> On 12/25/2011 07:59 PM, Cong Wang wrote: >> >>> On Fri, 23 Dec 2011 at 08:04 GMT, Dave Young wrote: >>>> Option --ctty will optionally add setsid binary to dracut's image. >>>> >>>> During runtime, if rd.ctty is set and is a character device, >>>> emergency shells will be spawned with job control. >>>> >>>> in case no ctty was provided, shell was spawned without caring about >>>> /dev/console. Also, the ctty is more opportunistic. If the image was >>>> generated with --ctty, we will fallback to /dev/tty1 if rc.ctty is >>>> invalid or missing. Otherwise we spawn standard shell on /dev/console >>>> >>>> Signed-off-by: Michal Soltys >>>> Signed-off-by: Dave Young >>> >>> IIRC, Michal is the author of this patch? If so, you need to >>> add "From:" in the beginning of this patch... >> >> >> It does not apply on the usrmove branch, I refreshed it based on this >> branch, so maybe add sighed-off-by of Michal is ok. Michal? any suggestion? > > I think the correct way to handle this is: > > 1. Add From: Michal Soltys > 2. Add S-o-b: Signed-off-by: Michal Soltys > 3. Add your S-o-b: Signed-off-by: Dave Young > 4. Add one more line: [dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org: Rebased to usrmove branch] > > At least this is what Andrew Morton did for linux kernel patches in mmotm. Ok, good to know, Will resend > -- > To unsubscribe from this list: send the line "unsubscribe initramfs" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks Dave