Re: [PATCH 1/5 branch usrmove v2] deal common part of etc passwd in 99base

[Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On 12/29/2011 05:48 PM, Cong Wang wrote:

> On Thu, Dec 29, 2011 at 5:45 PM, Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>> On 12/29/2011 05:27 PM, Cong Wang wrote:
>>> The nfs module still uses "/" as home of root, while ssh module uses
>>> "/root". With you patches, you changed to "/root" for both nfs and
>>> ssh, which *maybe* a problem for nfs module since you didn't test it.
>>
>>
>> I tested nfs boot as well, it works ok with $HOME=/root
> 
> Ok, will change to "/root" too.
> 
>>
>> Also if you add both ssh-client and nfs, what's the result of /etc/passwd?
> 
> If the line "root:" exists before,
> 
>  egrep -q '^root:' "$initdir/etc/passwd" 2>/dev/null || echo
> 'root:x:0:0::/:/bin/sh' >> "$initdir/etc/passwd"
> 
> egrep will succeed and echo will not be executed...



Yes, but who knows which module will be added firstly, maybe there's
other module do this in future.

But if nfs also use /root as HOME it will be ok currently


-- 
Thanks
Dave