From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Cong Wang <xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] 98usrmount: don't pass fstab fs options as fsck options
Date: Mon, 16 Jan 2012 11:10:10 +0100 [thread overview]
Message-ID: <4F13F782.3060409@redhat.com> (raw)
In-Reply-To: <jepocb$nc5$2@dough.gmane.org>
On 13.01.2012 18:07, Cong Wang wrote:
> On Thu, 12 Jan 2012 at 11:48 GMT, Amadeusz Żołnowski <aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org> wrote:
>> For example for line in /etc/fstab:
>>
>> /dev/vg/usr /usr ext4 nosuid,nodev 0 2
>>
>> fsck_single is called as follows:
>>
>> fsck_single /dev/vg/usr ext4 nosuid,nodev
>>
>> and this eventually resolves to:
>>
>> e2fsck -a nosuid,nodev /dev/vg/usr
>>
>> which causes e2fsck usage error.
>> ---
>> modules.d/98usrmount/mount-usr.sh | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/modules.d/98usrmount/mount-usr.sh b/modules.d/98usrmount/mount-usr.sh
>> index a61f935..fc205d5 100755
>> --- a/modules.d/98usrmount/mount-usr.sh
>> +++ b/modules.d/98usrmount/mount-usr.sh
>> @@ -19,7 +19,7 @@ mount_usr()
>>
>> if [ "x$_usr_found" != "x" ]; then
>> # we have to mount /usr
>> - fsck_single "$_dev" "$_fs" "$_opts"
>> + fsck_single "$_dev" "$_fs"
>
> Yes, this change makes sense.
>
>> _ret=$?
>> echo $_ret >/run/initramfs/usr-fsck
>> if [ $_ret -ne 255 ]; then
>> @@ -29,4 +29,4 @@ mount_usr()
>> fi
>> }
>>
>> -mount_usr
>> \ No newline at end of file
>> +mount_usr
>
> But what is this one??
That just adds a newline at the end of the file, IIRC
next prev parent reply other threads:[~2012-01-16 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 11:48 [PATCH] 98usrmount: don't pass fstab fs options as fsck options Amadeusz Żołnowski
2012-01-13 17:07 ` Cong Wang
2012-01-16 10:10 ` Harald Hoyer [this message]
2012-01-25 13:10 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F13F782.3060409@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox