From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [PATCH] deal with nfs in fstab-sys Date: Mon, 30 Jan 2012 17:12:01 +0800 Message-ID: <4F265EE1.7010505@gmail.com> References: <20120130064451.GA7125@darkstar.nay.redhat.com> <4F2657B4.3030200@redhat.com> <4F26581B.4040305@gmail.com> <4F265CAA.2080804@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=jqUAJycDBwwunkZjIvg/80uysTpYSY+nLoMThsKhHUg=; b=O7iv1/SoX6oZCEZC23ZloXzZTX7/Ms8EY7G24mo3TmhI/iXxn91Y+h6RL+8kwCZiaQ Ox6DZjyRh4/CCEwDUPS6Zud+MXUpGs7HxOcrYrjHt/FqU7x0/Tyh6w2q2Ld5HDZomAH8 XbTaQPBZI2QYb3pzqFbAuVsNEY1OZW9JrvdJs= In-Reply-To: <4F265CAA.2080804-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Dave Young Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 01/30/2012 05:02 PM, Dave Young wrote: > On 01/30/2012 04:43 PM, Cong Wang wrote: > >> On 01/30/2012 04:41 PM, Dave Young wrote: >>> On 01/30/2012 04:20 PM, Cong Wang wrote: >>> >>>> On Mon, 30 Jan 2012 at 06:44 GMT, Dave Young wrote: >>>>> If we need to mount nonroot nfs in fstab we also need to launch rpc >>>>> processes >>>>> Add nfs-start-rpc code, also do not check and fsck $_dev in this case >>>> >>>> Isn't it nfs module's responsibility to call nfs-start-rpc code? >>>> Why do you put it in fs-systab? >>> >>> >>> nfs know nothing about fstab mount, it only deal with nfsroot thing. So >>> I have to do this in fstab-sys >> >> Sure, but nfs module knows it needs to start rpc before mounting NFS. >> >> So, what's the problem if we call nfs-start-rpc script in pre-pivot hook >> of nfs module (before mount-sys.sh, of course)? > > > Actually nfs-start-rpc need to know the fs is nfs or nfs4, If add it as > a hook, how does it accept the argument? I think you can start rpc daemons unconditionally, no matter if it is nfs4 or nfs.