mkinitrd unification across distributions
 help / color / mirror / Atom feed
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] wait_for_if_up fix
Date: Wed, 15 Feb 2012 09:22:50 +0100	[thread overview]
Message-ID: <4F3B6B5A.6070007@redhat.com> (raw)
In-Reply-To: <20120215064027.GA30110-4/PLUo9XfK+sDdueE5tM26fLeoKvNuZc@public.gmane.org>

Am 15.02.2012 07:40, schrieb Dave Young:
> wait_for_if_up will always return 0, fix it by change to use =~ to
> check if link state is up
> 
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  modules.d/99base/dracut-lib.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/modules.d/99base/dracut-lib.sh b/modules.d/99base/dracut-lib.sh
> index 6b70adf..85d4925 100755
> --- a/modules.d/99base/dracut-lib.sh
> +++ b/modules.d/99base/dracut-lib.sh
> @@ -385,7 +385,7 @@ wait_for_if_up() {
>      local cnt=0
>      while [ $cnt -lt 200 ]; do
>          li=$(ip link show $1)
> -        [ -z "${li##*state UP*}" ] && return 0
> +        [[ "$li" =~ "state UP" ]] && return 0
>          sleep 0.1
>          cnt=$(($cnt+1))
>      done


This is not posix shell compliant.

$ PS1="$ " dash
$ li="my state DOWN test"
$ [ -z "${li##*state UP*}" ] && echo OK
$ li="my state UP test"
$ [ -z "${li##*state UP*}" ] && echo OK
OK
$

works for me

  parent reply	other threads:[~2012-02-15  8:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15  6:40 [PATCH 2/3] wait_for_if_up fix Dave Young
     [not found] ` <20120215064027.GA30110-4/PLUo9XfK+sDdueE5tM26fLeoKvNuZc@public.gmane.org>
2012-02-15  8:22   ` Harald Hoyer [this message]
     [not found]     ` <4F3B6B5A.6070007-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-02-16  1:12       ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3B6B5A.6070007@redhat.com \
    --to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox