mkinitrd unification across distributions
 help / color / mirror / Atom feed
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Will Woods <wwoods-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Make sure 'set -x' gets turned back on in wait_for_loginit
Date: Thu, 15 Mar 2012 11:23:23 +0100	[thread overview]
Message-ID: <4F61C31B.1000305@redhat.com> (raw)
In-Reply-To: <1331759389-23864-1-git-send-email-wwoods-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Am 14.03.2012 22:09, schrieb Will Woods:
> wait_for_loginit does set +x (to turn off debugging temporarily), but
> sometimes it would return before turning it back on. Move the set +x
> line to fix that, then use 'setdebug' to make sure we don't turn it back
> on unless it was needed.
> ---
>  modules.d/99base/dracut-lib.sh |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules.d/99base/dracut-lib.sh b/modules.d/99base/dracut-lib.sh
> index f0d426c..6f506b6 100755
> --- a/modules.d/99base/dracut-lib.sh
> +++ b/modules.d/99base/dracut-lib.sh
> @@ -756,9 +756,9 @@ need_shutdown() {
>  
>  wait_for_loginit()
>  {
> -    set +x
>      [ "$RD_DEBUG" = "yes" ] || return
>      [ -e /run/initramfs/loginit.pipe ] || return
> +    set +x
>      echo "DRACUT_LOG_END"
>      exec 0<>/dev/console 1<>/dev/console 2<>/dev/console
>          # wait for loginit
> @@ -778,7 +778,7 @@ wait_for_loginit()
>          kill $(while read line;do echo $line;done</run/initramfs/loginit.pid)
>      fi
>  
> -    set -x
> +    setdebug
>      rm -f /run/initramfs/loginit.pipe /run/initramfs/loginit.pid
>  }
>  

pushed

      parent reply	other threads:[~2012-03-15 10:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 21:09 [PATCH] Make sure 'set -x' gets turned back on in wait_for_loginit Will Woods
     [not found] ` <1331759389-23864-1-git-send-email-wwoods-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-03-15 10:23   ` Harald Hoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F61C31B.1000305@redhat.com \
    --to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wwoods-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox