From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Cong Wang <xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] add option --printsize
Date: Mon, 21 May 2012 10:50:53 +0200 [thread overview]
Message-ID: <4FBA01ED.2000001@redhat.com> (raw)
In-Reply-To: <4FBA003D.50103-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Am 21.05.2012 10:43, schrieb Cong Wang:
> On 05/21/2012 04:37 PM, Dave Young wrote:
>> Add --printsize for measuring module installed size to initramfs
>>
> ...
>> +
>> + #print the module install size
>> + if [ -n "$printsize" ]; then
>> + _isize_new=$(du -sk ${initdir}|cut -f1)
>> + _isize_delta=$(($_isize_new - $_isize))
>> + echo "$_d_mod install size: ${_isize_delta}k"
>> + _isize=$_isize_new
>> + fi
>> fi
>
> Yeah, it is a nice feature, to calculate the module installation size by delta
> of the whole initrd size.
>
> Could you include the sample output in the changelog?
>
> Thanks.
What about files used by many modules, like shared libraries and tools? The
output should be taken with a grain of salt.
next prev parent reply other threads:[~2012-05-21 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 8:37 [PATCH] add option --printsize Dave Young
[not found] ` <20120521083706.GA3040-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2012-05-21 8:43 ` Cong Wang
[not found] ` <4FBA003D.50103-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-05-21 8:50 ` Harald Hoyer [this message]
[not found] ` <4FBA01ED.2000001-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-21 8:57 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA01ED.2000001@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox