From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Cong Wang <amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Cong Wang
<xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [RFC PATCH 3/3] Avoid generating udev rules for vlan interface
Date: Mon, 21 May 2012 11:25:11 +0200 [thread overview]
Message-ID: <4FBA09F7.4030003@redhat.com> (raw)
In-Reply-To: <1337591686-31875-3-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Am 21.05.2012 11:14, schrieb Cong Wang:
> From: Cong Wang <xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Vlan device has the same mac address with its physical device,
> if we generate udev rules for vlan NIC too, its physical device
> name will be override.
>
> I used an ugly hack in ifname-genrules.sh, don't know if we have any
> better ways to fix this?
>
> Cc: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Cc: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Cong Wang <xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> modules.d/40network/ifname-genrules.sh | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/modules.d/40network/ifname-genrules.sh b/modules.d/40network/ifname-genrules.sh
> index e188c88..b36f167 100755
> --- a/modules.d/40network/ifname-genrules.sh
> +++ b/modules.d/40network/ifname-genrules.sh
> @@ -10,7 +10,11 @@ fi
> {
> for p in $(getargs ifname=); do
> parse_ifname_opts $p
> - printf 'SUBSYSTEM=="net", ACTION=="add", DRIVERS=="?*", ATTR{address}=="%s", ATTR{type}=="1", NAME="%s"\n' "$ifname_mac" "$ifname_if"
> + #Hack: vlan device has the same mac address with its physical device
> + [ -e /tmp/vlan.info ] && source /tmp/vlan.info
> + if [ "$ifname_if" != "$vlanname" ]; then
> + printf 'SUBSYSTEM=="net", ACTION=="add", DRIVERS=="?*", ATTR{address}=="%s", ATTR{type}=="1", NAME="%s"\n' "$ifname_mac" "$ifname_if"
> + fi
> done
>
> # Rename non named interfaces out of the way for named ones.
Maybe one of the /sys attributes indicate, that it is a vlan interface?
next prev parent reply other threads:[~2012-05-21 9:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 9:14 [RFC PATCH 1/3] Add vlan support in network module Cong Wang
[not found] ` <1337591686-31875-1-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-21 9:14 ` [RFC PATCH 2/3] Remove netroot check in cmdline parsing code Cong Wang
2012-05-21 9:14 ` [RFC PATCH 3/3] Avoid generating udev rules for vlan interface Cong Wang
[not found] ` <1337591686-31875-3-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-21 9:25 ` Harald Hoyer [this message]
[not found] ` <4FBA09F7.4030003-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-21 9:31 ` Cong Wang
[not found] ` <4FBA0B8D.1070708-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-05-21 9:44 ` Harald Hoyer
[not found] ` <4FBA0E7E.1070004-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-21 10:19 ` Cong Wang
[not found] ` <4FBA1698.3090006-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-05-21 11:27 ` Harald Hoyer
[not found] ` <4FBA26A1.6010109-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-22 1:43 ` Cong Wang
[not found] ` <4FBAEF49.60108-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-05-22 9:32 ` Harald Hoyer
[not found] ` <4FBB5D3D.2080101-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-22 13:43 ` Cong Wang
[not found] ` <4FBB97E7.6060804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-05-23 9:45 ` Harald Hoyer
[not found] ` <4FBCB1AC.907-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-24 4:50 ` Cong Wang
2012-05-21 9:22 ` [RFC PATCH 1/3] Add vlan support in network module Harald Hoyer
[not found] ` <4FBA094B.5040303-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-21 9:26 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA09F7.4030003@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox