From: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] use check_block_and_slaves in for_each_host_dev_and_slaves
Date: Tue, 28 Aug 2012 10:08:14 +0800 [thread overview]
Message-ID: <503C280E.6000505@redhat.com> (raw)
In-Reply-To: <20120828020549.GA6961-je1gSBvt1Td3da3rpXeqgR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
On 08/28/2012 10:05 AM, Dave Young wrote:
>
> for_each_host_dev_and_slaves currently is used in some module check()
> functions and it's not necessary iterate all slaves. So use
> check_block_and_slaves instead of check_block_and_slaves_all is fine.
Hi, harald
Thanks for cleanup the redundant "echo" lines in my last patch series
Could you apply this cleanup as well?
>
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> dracut-functions.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- dracut.orig/dracut-functions.sh
> +++ dracut/dracut-functions.sh
> @@ -468,7 +468,7 @@ for_each_host_dev_and_slaves()
> local _dev
> for _dev in ${host_devs[@]}; do
> [[ -b "$_dev" ]] || continue
> - check_block_and_slaves_all $_func $(get_maj_min $_dev) && return 0
> + check_block_and_slaves $_func $(get_maj_min $_dev) && return 0
> done
> return 1
> }
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks
Dave
prev parent reply other threads:[~2012-08-28 2:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 2:05 [PATCH] use check_block_and_slaves in for_each_host_dev_and_slaves Dave Young
[not found] ` <20120828020549.GA6961-je1gSBvt1Td3da3rpXeqgR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2012-08-28 2:08 ` Dave Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503C280E.6000505@redhat.com \
--to=dyoung-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox