From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Daniel Drake <dsd-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] busybox: fix installation from /sbin/busybox
Date: Wed, 26 Sep 2012 11:50:33 +0200 [thread overview]
Message-ID: <5062CFE9.1050102@redhat.com> (raw)
In-Reply-To: <20120925224228.25BC8FAABE-2+9YHz4BXxlLDiiyqF6/jw@public.gmane.org>
Am 26.09.2012 00:42, schrieb Daniel Drake:
> "inst busybox" no longer seems to work when busybox is at
> /sbin/busybox. Reproduced on Fedora 18 (dracut-023-39.git20120910).
>
> Use type -P to find the full path to busybox to solve this problem.
> ---
> modules.d/05busybox/module-setup.sh | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/modules.d/05busybox/module-setup.sh b/modules.d/05busybox/module-setup.sh
> index 2e9ead8..e0ef178 100755
> --- a/modules.d/05busybox/module-setup.sh
> +++ b/modules.d/05busybox/module-setup.sh
> @@ -13,9 +13,10 @@ depends() {
> }
>
> install() {
> - local _i _progs _path
> - inst busybox /usr/bin/busybox
> - for _i in `/sbin/busybox | sed -ne '1,/Currently/!{s/,//g; s/busybox//g; p}'`
> + local _i _progs _path _busybox
> + _busybox=$(type -P busybox)
> + inst $_busybox /usr/bin/busybox
> + for _i in `$_busybox | sed -ne '1,/Currently/!{s/,//g; s/busybox//g; p}'`
> do
> _progs="$_progs $_i"
> done
>
Thanks! Pushed.
prev parent reply other threads:[~2012-09-26 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 22:42 [PATCH] busybox: fix installation from /sbin/busybox Daniel Drake
[not found] ` <20120925224228.25BC8FAABE-2+9YHz4BXxlLDiiyqF6/jw@public.gmane.org>
2012-09-26 9:50 ` Harald Hoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5062CFE9.1050102@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dsd-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox