From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: WANG Chao <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] 40network/ifup.sh: do_static() and do_ipv6auto return 0 if no errors.
Date: Fri, 19 Oct 2012 13:00:07 +0200 [thread overview]
Message-ID: <508132B7.5090801@redhat.com> (raw)
In-Reply-To: <1350549808-8891-1-git-send-email-chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Am 18.10.2012 10:43, schrieb WANG Chao:
> Commit a0be1ed removes some lines from do_static() and do_ipv6auto().
>
> When $hostname is empty, do_static() and do_ipv6auto() will return 1
> and fails to run setup_net at the last of ifup.sh
>
> Signed-off-by: WANG Chao <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> modules.d/40network/ifup.sh | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/modules.d/40network/ifup.sh b/modules.d/40network/ifup.sh
> index 95289c9..db233de 100755
> --- a/modules.d/40network/ifup.sh
> +++ b/modules.d/40network/ifup.sh
> @@ -88,6 +88,8 @@ do_ipv6auto() {
> wait_for_if_up $netif
>
> [ -n "$hostname" ] && echo "echo $hostname > /proc/sys/kernel/hostname" > /tmp/net.$netif.hostname
> +
> + return 0
> }
>
> # Handle static ip configuration
> @@ -108,6 +110,8 @@ do_static() {
>
> [ -n "$gw" ] && echo ip route add default via $gw dev $netif > /tmp/net.$netif.gw
> [ -n "$hostname" ] && echo "echo $hostname > /proc/sys/kernel/hostname" > /tmp/net.$netif.hostname
> +
> + return 0
> }
>
> # loopback is always handled the same way
>
https://admin.fedoraproject.org/updates/dracut-024-5.git20121019.fc18
prev parent reply other threads:[~2012-10-19 11:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 8:43 [PATCH] 40network/ifup.sh: do_static() and do_ipv6auto return 0 if no errors WANG Chao
[not found] ` <1350549808-8891-1-git-send-email-chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-10-19 11:00 ` Harald Hoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508132B7.5090801@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox