From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: WANG Chao <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] 50drm: Install dracut 50drm module in hostonly mode when drm driver is currently in use.
Date: Wed, 29 May 2013 10:40:26 +0200 [thread overview]
Message-ID: <51A5BEFA.7090101@redhat.com> (raw)
In-Reply-To: <51A56BC8.2010205-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 05/29/2013 04:45 AM, Dave Young wrote:
> On 05/28/2013 08:09 PM, Harald Hoyer wrote:
>> On 05/24/2013 10:22 AM, WANG Chao wrote:
>>> Now only 50plymouth module can pull in 50drm and that's very limited.
>>> Because KMS capable drm drivers are much needed in initrd to have a
>>> frame buffer console on the screen.
>>>
>>> Particularly, when building kdump initrd, plymouth module is omitted,
>>> but drm is necessary to setup a working screen for one sitting in front
>>> of a monitor.
>>>
>>> Signed-off-by: WANG Chao <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>> ---
>>> modules.d/50drm/module-setup.sh | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/modules.d/50drm/module-setup.sh b/modules.d/50drm/module-setup.sh
>>> index bf33c5b..648e8f4 100644
>>> --- a/modules.d/50drm/module-setup.sh
>>> +++ b/modules.d/50drm/module-setup.sh
>>> @@ -3,6 +3,10 @@
>>> # ex: ts=8 sw=4 sts=4 et filetype=sh
>>>
>>> check() {
>>> + if [[ $hostonly ]] && [ -d /sys/module/drm/drivers ]; then
>>> + return 0
>>> + fi
>>> +
>>> return 255
>>> }
>>>
>>>
>>
>> Hmm, why not let the kdump module depend on drm?
>
> If you do not like it we can consider add it to kdump module..
>
>>
>> depends() {
>> echo drm
>> }
>>
>> Anyway, do we really need drm for a simple console? Those drivers are really
>> really big and take a long time to load and initialize?
>
> It's a little awkward, after kernel crashing suppose 1st kernel is in
> kms mode, it can not reset to nomodeset, so screen will keep black.
>
> There's no such issue in normal initramfs because bios always reset
> devices for us.
>
Ah! Thanks for the clarification! That makes sense. Because this happens only
for kexec, I suggest to add the dependency to the kdump module.
prev parent reply other threads:[~2013-05-29 8:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 8:22 [PATCH] 50drm: Install dracut 50drm module in hostonly mode when drm driver is currently in use WANG Chao
[not found] ` <1369383763-24956-1-git-send-email-chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-28 12:09 ` Harald Hoyer
[not found] ` <51A49E65.9000206-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-29 2:45 ` Dave Young
[not found] ` <51A56BC8.2010205-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-29 6:57 ` WANG Chao
[not found] ` <20130529065726.GA28070-UAAZkH0G2Ts1naxU1pY8ZxcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
2013-05-29 9:44 ` Harald Hoyer
[not found] ` <51A5CDE9.4090808-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-29 10:41 ` WANG Chao
[not found] ` <20130529104112.GA3727-UAAZkH0G2Ts1naxU1pY8ZxcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
2013-05-29 10:54 ` Harald Hoyer
[not found] ` <51A5DE55.7020801-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-29 15:12 ` WANG Chao
2013-05-29 8:40 ` Harald Hoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A5BEFA.7090101@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox