mkinitrd unification across distributions
 help / color / mirror / Atom feed
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: WANG Chao <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] selinux: umount $NEWROOT/dev and its submounts
Date: Tue, 18 Jun 2013 09:01:58 +0200	[thread overview]
Message-ID: <51C005E6.5030206@redhat.com> (raw)
In-Reply-To: <20130618055804.GA3612-UAAZkH0G2Ts1naxU1pY8ZxcY2uh10dtjAL8bYrjMMd8@public.gmane.org>

On 06/18/2013 07:58 AM, WANG Chao wrote:
> $NEWROOT/dev and its submounts should be umounted after we use it.
> Otherwise it fails other scripts that umount /sysroot only.
> 
> Signed-off-by: WANG Chao <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  modules.d/98selinux/selinux-loadpolicy.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/modules.d/98selinux/selinux-loadpolicy.sh b/modules.d/98selinux/selinux-loadpolicy.sh
> index 5dddfc2..436ee6b 100755
> --- a/modules.d/98selinux/selinux-loadpolicy.sh
> +++ b/modules.d/98selinux/selinux-loadpolicy.sh
> @@ -48,6 +48,7 @@ rd_load_policy()
>              [ -e "$NEWROOT"/.autorelabel ] && LANG=C /usr/sbin/setenforce 0
>              mount --rbind /dev "$NEWROOT/dev"
>              LANG=C chroot "$NEWROOT" /sbin/restorecon -R /dev
> +            umount -R "$NEWROOT/dev"
>              return 0
>          fi
>  
> 


Thanks! Pushed.

      parent reply	other threads:[~2013-06-18  7:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18  5:58 [PATCH] selinux: umount $NEWROOT/dev and its submounts WANG Chao
     [not found] ` <20130618055804.GA3612-UAAZkH0G2Ts1naxU1pY8ZxcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
2013-06-18  7:01   ` Harald Hoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C005E6.5030206@redhat.com \
    --to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox