From: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] omit drivers fix
Date: Wed, 21 Aug 2013 15:44:55 +0800 [thread overview]
Message-ID: <52146FF7.8050904@redhat.com> (raw)
In-Reply-To: <5203350e.L97Tg2G2L47GaDix%dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 08/08/2013 02:05 PM, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org wrote:
>
> Because omit_drivers list use underline always, so when maching with it
> the _mod need to be converted as well or sometimes omit-drivers will fail
> silently.
>
> Fix this by replace '-' with '_' in instmods function.
>
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> dracut-functions.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- dracut.orig/dracut-functions.sh
> +++ dracut/dracut-functions.sh
> @@ -1617,7 +1617,8 @@ instmods() {
> return $_ret
> fi
>
> - if [[ $omit_drivers ]] && [[ "$1" =~ $omit_drivers ]]; then
> + _mod=${_mod/-/_}
> + if [[ $omit_drivers ]] && [[ "$_mod" =~ $omit_drivers ]]; then
> dinfo "Omitting driver ${_mod##$srcmods}"
> return 0
> fi
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Hi, Harald
Could you help to review this patch?
--
Thanks
Dave
next prev parent reply other threads:[~2013-08-21 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 6:05 [PATCH] omit drivers fix dyoung-H+wXaHxf7aLQT0dZR+AlfA
[not found] ` <5203350e.L97Tg2G2L47GaDix%dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-08-21 7:44 ` Dave Young [this message]
[not found] ` <52146FF7.8050904-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-08-21 8:21 ` Harald Hoyer
2013-08-21 8:25 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52146FF7.8050904@redhat.com \
--to=dyoung-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=Harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox