Re: [PATCH 2/2] crypt: Only write udev rules to unlock when the device is added

[James Lee <jlee-RWYTM8lfiZY4k1Tz1RznXQC/G2K4zDHf@public.gmane.org>]

On 12/26/2013 04:26 PM, Colin Guthrie wrote:
> It seems that when the device is unlocked, it will trigger a change
> event which in turn re-writes the settled job which was diligently
> removed after it was run.
> 
> Due to the previous fix, this isn't crazy important as the triggered
> job should exit, but avoiding this in the first place is still
> desirable.
> ---
> 
> Note, I'm not sure if this is wise or not. The previous patch alone
> fixes the issue, so this is just an efficiency saving. It might be
> that this is needed - e.g. if you have any encrypted volume on top
> of some other mapped device such as RAID, so please only apply this
> patch if you are sure it will not cause regressions!!

Actually, after some more testing with this particular patch, I'm not so
sure about it.  I have encrypted devices that depend on other encrypted
devices.  With this patch applied I sometimes get prompted for
passphrases out of order.

I'll try to do some more digging and figure out why.

Thanks,

James