From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Stig Telfer <stelfer-WVYJKLFxKCc@public.gmane.org>,
"initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] dracut-lib.sh: bugfix for pidof function
Date: Tue, 28 Jan 2014 15:37:12 +0100 [thread overview]
Message-ID: <52E7C098.5050502@redhat.com> (raw)
In-Reply-To: <E86DFAF410366A40AD1683994061D9D608FDCB-aOe8g7e11MUSZAcGdq5asVgOPcOSbvolAL8bYrjMMd8@public.gmane.org>
On 01/24/2014 04:19 PM, Stig Telfer wrote:
> It appears there is a simple substitution error in the pidof shell function which causes it to fail to find processes. In my case, processes started by 95nfs are not terminated in the cleanup hook. This causes knock-on effects disturbing the root filesystem service dependencies.
>
> Enjoy,
> Stig Telfer
>
> diff --git a/modules.d/99base/dracut-lib.sh b/modules.d/99base/dracut-lib.sh
> index 85f7cdf..3f10bc1 100755
> --- a/modules.d/99base/dracut-lib.sh
> +++ b/modules.d/99base/dracut-lib.sh
> @@ -969,7 +969,7 @@ if ! command -v pidof >/dev/null 2>/dev/null; then
> for i in /proc/*/exe; do
> [ -e "$i" ] || return 1
> if [ -n "$_exe" ]; then
> - [ "$i" -ef "$_cmd" ] || continue
> + [ "$i" -ef "$_exe" ] || continue
> else
> _rl=$(readlink -f "$i");
> [ "${_rl%/$_cmd}" != "$_rl" ] || continue
>
>
Thanks! Pushed.
prev parent reply other threads:[~2014-01-28 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 15:19 [PATCH] dracut-lib.sh: bugfix for pidof function Stig Telfer
[not found] ` <E86DFAF410366A40AD1683994061D9D608FDCB-aOe8g7e11MUSZAcGdq5asVgOPcOSbvolAL8bYrjMMd8@public.gmane.org>
2014-01-28 14:37 ` Harald Hoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E7C098.5050502@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stelfer-WVYJKLFxKCc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox