Bug in dracut-functions.sh@225(print_vars)

Bug in dracut-functions.sh@225(print_vars)

[Sebastian Köln]

Hello,

I stubled upon the following bug (dracut --verbose output):

> ...
> //usr/lib/dracut/modules.d/10i18n/module-setup.sh@132(install_local_i18n): 
EXT_KEYMAPS='backspace keypad euro2'
> ...
> /usr/lib/dracut/dracut-functions.sh@224(print_vars): eval printf -v _value 
%s '$EXT_KEYMAPS'
> //usr/lib/dracut/dracut-functions.sh@224(print_vars): printf -v _value %s 
backspace keypad euro2
> /usr/lib/dracut/dracut-functions.sh@225(print_vars): [[ -n 
backspacekeypadeuro2 ]]
> /usr/lib/dracut/dracut-functions.sh@225(print_vars): printf '%s=\"%s\"\n' 
EXT_KEYMAPS backspacekeypadeuro2

the "eval" line of print_vars
needs to re replaced by
> eval printf -v _value "%s" \""\$$_var"\"

the modified function is then:

> # Function prints global variables in format name=value line by line.
> # $@ = list of global variables' name
> print_vars() {
>     local _var _value
> 
>     for _var in "$@"
>     do
>         eval printf -v _value "%s" \""\$$_var"\"
>         [[ ${_value} ]] && printf '%s="%s"\n' "$_var" "$_value"
>     done
> }

this produces the correct result.

Re: Bug in dracut-functions.sh@225(print_vars)

[Harald Hoyer]

On 06.04.2014 13:38, Sebastian Köln wrote:
> Hello,
> 
> I stubled upon the following bug (dracut --verbose output):
> 
>> ...
>> //usr/lib/dracut/modules.d/10i18n/module-setup.sh@132(install_local_i18n): 
> EXT_KEYMAPS='backspace keypad euro2'
>> ...
>> /usr/lib/dracut/dracut-functions.sh@224(print_vars): eval printf -v _value 
> %s '$EXT_KEYMAPS'
>> //usr/lib/dracut/dracut-functions.sh@224(print_vars): printf -v _value %s 
> backspace keypad euro2
>> /usr/lib/dracut/dracut-functions.sh@225(print_vars): [[ -n 
> backspacekeypadeuro2 ]]
>> /usr/lib/dracut/dracut-functions.sh@225(print_vars): printf '%s=\"%s\"\n' 
> EXT_KEYMAPS backspacekeypadeuro2
> 
> the "eval" line of print_vars
> needs to re replaced by
>> eval printf -v _value "%s" \""\$$_var"\"
> 
> the modified function is then:
> 
>> # Function prints global variables in format name=value line by line.
>> # $@ = list of global variables' name
>> print_vars() {
>>     local _var _value
>>
>>     for _var in "$@"
>>     do
>>         eval printf -v _value "%s" \""\$$_var"\"
>>         [[ ${_value} ]] && printf '%s="%s"\n' "$_var" "$_value"
>>     done
>> }
> 
> this produces the correct result.


Thanks!

http://git.kernel.org/cgit/boot/dracut/dracut.git/commit/?id=7a94a4326f0641396125acb2b444b562224457a1