mkinitrd unification across distributions
 help / color / mirror / Atom feed
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Brian C. Lane" <bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Support spaces in mount_nfs (#1109933)
Date: Wed, 10 Sep 2014 11:08:27 +0200	[thread overview]
Message-ID: <5410150B.6000008@redhat.com> (raw)
In-Reply-To: <1408645911-3268-1-git-send-email-bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On 21.08.2014 20:31, Brian C. Lane wrote:
> nfs paths may contain spaces, make sure they are preserved when passed
> to nfs_to_var and mount.
> 
> Related: rhbz#1109933
> ---
>  modules.d/95nfs/nfs-lib.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules.d/95nfs/nfs-lib.sh b/modules.d/95nfs/nfs-lib.sh
> index d5377fe..94d05b8 100755
> --- a/modules.d/95nfs/nfs-lib.sh
> +++ b/modules.d/95nfs/nfs-lib.sh
> @@ -125,7 +125,7 @@ munge_nfs_options() {
>  mount_nfs() {
>      local nfsroot="$1" mntdir="$2" netif="$3"
>      local nfs="" server="" path="" options=""
> -    nfs_to_var $nfsroot $netif
> +    nfs_to_var "$nfsroot" $netif
>      munge_nfs_options
>      if [ "$nfs" = "nfs4" ]; then
>          options=$options${nfslock:+,$nfslock}
> @@ -136,5 +136,5 @@ mount_nfs() {
>              && warn "Locks unsupported on NFSv{2,3}, using nolock" 1>&2
>          options=$options,nolock
>      fi
> -    mount -t $nfs -o$options $server:$path $mntdir
> +    mount -t $nfs -o$options "$server:$path" "$mntdir"
>  }
> 

Thanks! pushed

      parent reply	other threads:[~2014-09-10  9:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21 18:31 [PATCH] Support spaces in mount_nfs (#1109933) Brian C. Lane
     [not found] ` <1408645911-3268-1-git-send-email-bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-09-10  9:08   ` Harald Hoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5410150B.6000008@redhat.com \
    --to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox