public inbox for initramfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Lakhin <a.lahin-QLx1KmmFfsSQHXbzqtDRaA@public.gmane.org>
To: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Dracut is not processing last line of a kernel modules configuration file
Date: Fri, 26 Dec 2014 15:55:06 +0300	[thread overview]
Message-ID: <549D5AAA.8050408@ntcit-rosa.ru> (raw)

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

Hello,

I've found that dracut skips a kernel module if it's specified in 
/etc/modules-load.d/<module>.conf in a single line without EOL.
For example, when /etc/modules-load.d/krb5.conf contains the single line:
rpcsec_gss_krb5
(without end-of-line), I've got the error:
systemd-modules-load[]: Failed to find module 'rpcsec_gss_krb5'

and lsinitrd shows no such module in the initrd image.

Attached patch fixes the issue.

Best regards,
Alexander

[-- Attachment #2: dracut-037-process-last-line-of-mod.conf.patch --]
[-- Type: text/x-patch, Size: 599 bytes --]

diff -ru dracut-037/modules.d/98systemd/module-setup.sh dracut-037.new/modules.d/98systemd/module-setup.sh
--- dracut-037/modules.d/98systemd/module-setup.sh	2014-03-19 20:16:08.000000000 +0400
+++ dracut-037.new/modules.d/98systemd/module-setup.sh	2014-12-10 17:14:06.779593964 +0300
@@ -132,7 +132,8 @@
         local _line i
         for i in "$1"/*.conf; do
             [[ -f $i ]] || continue
-            while read _line; do
+            EOF=false; until $EOF ; do
+                read _line || EOF=true
                 case $_line in
                     \#*)
                         ;;

                 reply	other threads:[~2014-12-26 12:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549D5AAA.8050408@ntcit-rosa.ru \
    --to=a.lahin-qlx1kmmffssqhxbzqtdraa@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox