[PATCH] dracut-functions.sh: avoid tokenizing ldconfig output with 'read'

[PATCH] dracut-functions.sh: avoid tokenizing ldconfig output with 'read'

[Lubomir Rintel]

The space does not separate the elements reliably, spaces can be
embedded in parenthesized expressions too:

  libgmpxx.so.4 (libc6, hwcap: 0x0000000004000000) => /lib/sse2/libgmpxx.so.4
  libgmp.so.10 (libc6, hwcap: 0x0000000004000000) => /lib/sse2/libgmp.so.10

This results in dracut creating '0x0000000004000000' and '=>'
directories in the initramfs image.
---
 dracut-functions.sh | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/dracut-functions.sh b/dracut-functions.sh
index 410960d..37ddca2 100755
--- a/dracut-functions.sh
+++ b/dracut-functions.sh
@@ -104,17 +104,7 @@ fi
 
 ldconfig_paths()
 {
-    local a i
-    declare -A a
-    for i in $(
-        ldconfig -pN 2>/dev/null | grep -F '=>' | grep -E -v '/(lib|lib64|usr/lib|usr/lib64)/[^/]*$' | while read a b c d; do
-            d=${d%/*}
-            printf "%s\n" "$d";
-        done
-    ); do
-        a["$i"]=1;
-    done;
-    printf "%s\n" ${!a[@]}
+    ldconfig -pN 2>/dev/null | grep -E -v '/(lib|lib64|usr/lib|usr/lib64)/[^/]*$' | sed -n 's,.* => \(.*\)/.*,\1,p' | sort | uniq
 }
 
 # Detect lib paths
-- 
2.1.0

Re: [PATCH] dracut-functions.sh: avoid tokenizing ldconfig output with 'read'

[Harald Hoyer]

On 23.12.2014 22:03, Lubomir Rintel wrote:
> The space does not separate the elements reliably, spaces can be
> embedded in parenthesized expressions too:
> 
>   libgmpxx.so.4 (libc6, hwcap: 0x0000000004000000) => /lib/sse2/libgmpxx.so.4
>   libgmp.so.10 (libc6, hwcap: 0x0000000004000000) => /lib/sse2/libgmp.so.10
> 
> This results in dracut creating '0x0000000004000000' and '=>'
> directories in the initramfs image.
> ---
>  dracut-functions.sh | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/dracut-functions.sh b/dracut-functions.sh
> index 410960d..37ddca2 100755
> --- a/dracut-functions.sh
> +++ b/dracut-functions.sh
> @@ -104,17 +104,7 @@ fi
>  
>  ldconfig_paths()
>  {
> -    local a i
> -    declare -A a
> -    for i in $(
> -        ldconfig -pN 2>/dev/null | grep -F '=>' | grep -E -v '/(lib|lib64|usr/lib|usr/lib64)/[^/]*$' | while read a b c d; do
> -            d=${d%/*}
> -            printf "%s\n" "$d";
> -        done
> -    ); do
> -        a["$i"]=1;
> -    done;
> -    printf "%s\n" ${!a[@]}
> +    ldconfig -pN 2>/dev/null | grep -E -v '/(lib|lib64|usr/lib|usr/lib64)/[^/]*$' | sed -n 's,.* => \(.*\)/.*,\1,p' | sort | uniq
>  }
>  
>  # Detect lib paths
> 

Thanks! pushed