From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harald Hoyer Subject: Re: [patch 0/6] Revert action_on_fail patches Date: Fri, 13 Nov 2015 13:43:27 +0100 Message-ID: <5645DAEF.5040505@redhat.com> References: <20150831024314.798498962@redhat.com> <20150929081150.GD30623@dhcp-129-73.nay.redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150929081150.GD30623-sa4SJRhfYT7Js+WLOFIw6R/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Dave Young , initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org On 29.09.2015 10:11, Dave Young wrote: > On 08/31/15 at 10:43am, Dave Young wrote: >> Hi, >> >> action_on_fail was introduced originally for kdump error handling. >> Before the patches, dracut will drop into emergency shell for many >> failure cases, but kdump does not care about some of failures as >> long as vmcore can be saved successfully. Thus action_on_fail was >> introduced to fall to kdump service in case early failure in dracut. >> >> But later with new systemd services, there are cases that kdump >> script can never be called in case early dracut failure because of >> systemd service dependency issues. >> >> Thus there was below post which create a new kdump error handler >> systemd service: >> https://lists.stg.fedoraproject.org/archives/list/kexec-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org/thread/3EN63K2NDC6C545M5Z434VCHWDR3BCHD/ >> >> Now this action_on_fail interface was useless, nobody use it and >> it is broken with systemd sometimes. So I send this series to revert >> them one by one. >> > > Harald, ping > > Since the code is useless, IMHO it is odd to keep them and it will > cause trouble in the future for further fixes and improvements. > > What do you think? > > Thanks > Dave Thanks, pushed!