From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Minfei Huang <mhuang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] Add new file to export the common functions
Date: Mon, 2 May 2016 12:47:24 +0200 [thread overview]
Message-ID: <f032f0da-9ac5-5c23-ea83-66f1cd765080@redhat.com> (raw)
In-Reply-To: <20160502101707.GA12999-0VdLhd/A9Pl6Yz8KYMO23x/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
On 02.05.2016 12:17, Minfei Huang wrote:
> On 11/13/15 at 01:44pm, Harald Hoyer wrote:
>> On 29.10.2015 07:04, Minfei Huang wrote:
>>> Hi, Harald.
>>>
>>> Ping. Do you have any feedback about this patch?
>>>
>>> Thanks
>>> Minfei
>>
>> cleaned up dracut-functions.sh and moved dracut specific functions to
>> dracut-inist.sh
>
> Hi, Harald.
>
> The dracut exported lib dracut-functions.sh still cann't be sourced
> directly by third-party project, due to undefined variable initdir.
>
> Could you please help move following code to dracut-init.sh as well?
>
> if [[ "$(ln --help)" == *--relative* ]]; then
> ln_r() {
> ln -sfnr "${initdir}/$1" "${initdir}/$2"
> }
> else
> ln_r() {
> local _source=$1
> local _dest=$2
> [[ -d "${_dest%/*}" ]] && _dest=$(readlink -f "${_dest%/*}")/${_dest##*/}
> ln -sfn -- "$(convert_abs_rel "${_dest}" "${_source}")" "${initdir}/${_dest}"
> }
> fi
>
>
> Thanks
> Minfei
>
sure
prev parent reply other threads:[~2016-05-02 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 7:44 [PATCH] Add new file to export the common functions Minfei Huang
[not found] ` <1441871080-10392-1-git-send-email-mhuang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-10 8:02 ` Dracut GitHub Import Bot
2015-10-29 6:04 ` Minfei Huang
[not found] ` <20151029060453.GA32560-0VdLhd/A9Pl6Yz8KYMO23x/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2015-11-13 12:44 ` Harald Hoyer
[not found] ` <5645DB3D.5080606-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-02 10:17 ` Minfei Huang
[not found] ` <20160502101707.GA12999-0VdLhd/A9Pl6Yz8KYMO23x/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2016-05-02 10:47 ` Harald Hoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f032f0da-9ac5-5c23-ea83-66f1cd765080@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mhuang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox