From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniele Ceraolo Spurio Subject: Re: [PATCH 5/5] drm/i915: Expand subslice mask Date: Tue, 7 May 2019 14:16:10 -0700 Message-ID: <00b20669-e4a9-e3eb-5756-49c79a45451c@intel.com> References: <20190503213020.25628-1-stuart.summers@intel.com> <20190503213020.25628-6-stuart.summers@intel.com> <2fac0fe1df309711846000cfdfbe9019df16bd19.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0C1389F8B for ; Tue, 7 May 2019 21:15:56 +0000 (UTC) In-Reply-To: <2fac0fe1df309711846000cfdfbe9019df16bd19.camel@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Summers, Stuart" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org PHNuaXA+Cgo+Pgo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2lu Zm8uYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uYwo+ Pj4gQEAgLTg0LDE3ICs4NCw0NiBAQCB2b2lkIGludGVsX2RldmljZV9pbmZvX2R1bXBfZmxhZ3Mo Y29uc3Qgc3RydWN0Cj4+PiBpbnRlbF9kZXZpY2VfaW5mbyAqaW5mbywKPj4+ICAgICN1bmRlZiBQ UklOVF9GTEFHCj4+PiAgICB9Cj4+PiAgICAKPj4+ICsjZGVmaW5lIFNTX1NUUl9NQVhfU0laRSAo R0VOX01BWF9TVUJTTElDRV9TVFJJREUgKiAyICsgMSkKPj4+ICsKPj4+ICtzdGF0aWMgY2hhciAq Cj4+PiArc3Vic2xpY2VfcGVyX3NsaWNlX3N0cihjaGFyICpidWYsIHU4IHNpemUsIGNvbnN0IHN0 cnVjdAo+Pj4gc3NldV9kZXZfaW5mbyAqc3NldSwKPj4+ICsJCSAgICAgICB1OCBzbGljZSkKPj4+ ICt7Cj4+PiArCWludCBpOwo+Pj4gKwl1OCBzc19vZmZzZXQgPSBzbGljZSAqIHNzZXUtPnNzX3N0 cmlkZTsKPj4+ICsKPj4+ICsJR0VNX0JVR19PTihzbGljZSA+PSBzc2V1LT5tYXhfc2xpY2VzKTsK Pj4+ICsKPj4+ICsJLyogVHdvIEFTQ0lJIGNoYXJhY3RlciBoZXggcGx1cyBudWxsIHRlcm1pbmF0 b3IgKi8KPj4+ICsJR0VNX0JVR19PTihzaXplIDwgc3NldS0+c3Nfc3RyaWRlICogMiArIDEpOwo+ Pj4gKwo+Pj4gKwltZW1zZXQoYnVmLCAwLCBzaXplKTsKPj4+ICsKPj4+ICsJLyoKPj4+ICsJICog UHJpbnQgc3Vic2xpY2UgaW5mb3JtYXRpb24gaW4gcmV2ZXJzZSBvcmRlciB0byBtYXRjaAo+Pj4g KwkgKiB1c2Vyc3BhY2UgZXhwZWN0YXRpb25zLgo+Pj4gKwkgKi8KPj4+ICsJZm9yIChpID0gMDsg aSA8IHNzZXUtPnNzX3N0cmlkZTsgaSsrKQo+Pj4gKwkJc3ByaW50ZigmYnVmW2kgKiAyXSwgIiUw MngiLAo+Pj4gKwkJCXNzZXUtPnN1YnNsaWNlX21hc2tbc3Nfb2Zmc2V0ICsgc3NldS0+c3Nfc3Ry aWRlCj4+PiAtCj4+PiArCQkJCQkgICAgKGkgKyAxKV0pOwo+Pj4gKwo+Pj4gKwlyZXR1cm4gYnVm Owo+Pj4gK30KPj4+ICsKPj4+ICAgIHN0YXRpYyB2b2lkIHNzZXVfZHVtcChjb25zdCBzdHJ1Y3Qg c3NldV9kZXZfaW5mbyAqc3NldSwgc3RydWN0Cj4+PiBkcm1fcHJpbnRlciAqcCkKPj4+ICAgIHsK Pj4+ICAgIAlpbnQgczsKPj4+ICsJY2hhciBidWZbU1NfU1RSX01BWF9TSVpFXTsKPj4+ICAgIAo+ Pj4gICAgCWRybV9wcmludGYocCwgInNsaWNlIHRvdGFsOiAldSwgbWFzaz0lMDR4XG4iLAo+Pj4g ICAgCQkgICBod2VpZ2h0OChzc2V1LT5zbGljZV9tYXNrKSwgc3NldS0+c2xpY2VfbWFzayk7Cj4+ PiAgICAJZHJtX3ByaW50ZihwLCAic3Vic2xpY2UgdG90YWw6ICV1XG4iLAo+Pj4gaW50ZWxfc3Nl dV9zdWJzbGljZV90b3RhbChzc2V1KSk7Cj4+PiAgICAJZm9yIChzID0gMDsgcyA8IHNzZXUtPm1h eF9zbGljZXM7IHMrKykgewo+Pj4gLQkJZHJtX3ByaW50ZihwLCAic2xpY2UlZDogJXUgc3Vic2xp Y2VzLCBtYXNrPSUwNHhcbiIsCj4+PiArCQlkcm1fcHJpbnRmKHAsICJzbGljZSVkOiAldSBzdWJz bGljZXMsIG1hc2s9JXNcbiIsCj4+PiAgICAJCQkgICBzLCBpbnRlbF9zc2V1X3N1YnNsaWNlc19w ZXJfc2xpY2Uoc3NldSwgcyksCj4+PiAtCQkJICAgc3NldS0+c3Vic2xpY2VfbWFza1tzXSk7Cj4+ PiArCQkJICAgc3Vic2xpY2VfcGVyX3NsaWNlX3N0cihidWYsIEFSUkFZX1NJWkUoYnVmKSwKPj4+ IHNzZXUsIHMpKTsKPj4KPj4gTm93IHRoYXQgd2UgaGF2ZSBpbnRlbF9zc2V1X2dldF9zdWJzbGlj ZXMoKSBjYW4ndCB3ZSBqdXN0IHByaW50IHRoZQo+PiByZXR1cm4gZnJvbSB0aGF0IGluc3RlYWQg b2YgdXNpbmcgdGhlIGJ1ZmZlcj8KPiAKPiBJIHBlcnNvbmFsbHkgd291bGQgcHJlZmVyIHdlIGtl ZXAgdGhlIHN0cmluZ2lmeSBmdW5jdGlvbiBhcyBpdCBnaXZlcyBhCj4gbGl0dGxlIG1vcmUgZmxl eGliaWxpdHkuIERvIHlvdSBoYXZlIGEgc3Ryb25nIHByZWZlcmVuY2UgdG8gbW92ZSB0byBhCj4g ZGlyZWN0IHByaW50ayBmb3JtYXR0ZWQgc3RyaW5nPwo+IAoKSSBkbyBub3QsIGl0IGp1c3Qgc2Vl bWVkIGxpa2UgZHVwbGljYXRpb24gc2luY2UgeW91J3JlIG5vdCByZWFsbHkgdXNpbmcgCmFueSBl eHRyYSBmb3JtYXR0aW5nIG9yIG90aGVyIGZsZXhpYmlsaXR5IGluIGZpbGxpbmcgdGhlIGJ1ZmZl ci4gVGhpcyAKaXNuJ3QgYSBsb3Qgb2YgY29kZSwgc28gbWF5YmUgd2UgY2FuIHN3aXRjaCB0byBq dXN0IHVzaW5nIHRoZSB1MzIgZm9yIApub3cgYW5kIGFkZCB0aGlzIGJhY2sgaWYvd2hlbiB3ZSBk byByZXF1aXJlIHRoZSBmbGV4aWJpbGl0eT8KCj4+Cj4+Cj4+PiAgICAJfQo+Pj4gICAgCWRybV9w cmludGYocCwgIkVVIHRvdGFsOiAldVxuIiwgc3NldS0+ZXVfdG90YWwpOwo+Pj4gICAgCWRybV9w cmludGYocCwgIkVVIHBlciBzdWJzbGljZTogJXVcbiIsIHNzZXUtPmV1X3Blcl9zdWJzbGljZSk7 Cj4+Cj4+IDxzbmlwPgo+Pgo+Pj4gQEAgLTU1NSw2ICs1NzAsNyBAQCBzdGF0aWMgdm9pZCBoYXN3 ZWxsX3NzZXVfaW5mb19pbml0KHN0cnVjdAo+Pj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4+PiAgICAJc3RydWN0IHNzZXVfZGV2X2luZm8gKnNzZXUgPSAmUlVOVElNRV9JTkZPKGRldl9w cml2KS0+c3NldTsKPj4+ICAgIAl1MzIgZnVzZTE7Cj4+PiAgICAJaW50IHMsIHNzOwo+Pj4gKwl1 MzIgc3Vic2xpY2VfbWFzazsKPj4+ICAgIAo+Pj4gICAgCS8qCj4+PiAgICAJICogVGhlcmUgaXNu J3QgYSByZWdpc3RlciB0byB0ZWxsIHVzIGhvdyBtYW55IHNsaWNlcy9zdWJzbGljZXMuCj4+PiBX ZQo+Pj4gQEAgLTU2NiwyMiArNTgyLDE4IEBAIHN0YXRpYyB2b2lkIGhhc3dlbGxfc3NldV9pbmZv X2luaXQoc3RydWN0Cj4+PiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4+ICAgIAkJLyog ZmFsbCB0aHJvdWdoICovCj4+PiAgICAJY2FzZSAxOgo+Pj4gICAgCQlzc2V1LT5zbGljZV9tYXNr ID0gQklUKDApOwo+Pj4gLQkJc3NldS0+c3Vic2xpY2VfbWFza1swXSA9IEJJVCgwKTsKPj4+ICsJ CXN1YnNsaWNlX21hc2sgPSBCSVQoMCk7Cj4+PiAgICAJCWJyZWFrOwo+Pj4gICAgCWNhc2UgMjoK Pj4+ICAgIAkJc3NldS0+c2xpY2VfbWFzayA9IEJJVCgwKTsKPj4+IC0JCXNzZXUtPnN1YnNsaWNl X21hc2tbMF0gPSBCSVQoMCkgfCBCSVQoMSk7Cj4+PiArCQlzdWJzbGljZV9tYXNrID0gQklUKDAp IHwgQklUKDEpOwo+Pj4gICAgCQlicmVhazsKPj4+ICAgIAljYXNlIDM6Cj4+PiAgICAJCXNzZXUt PnNsaWNlX21hc2sgPSBCSVQoMCkgfCBCSVQoMSk7Cj4+PiAtCQlzc2V1LT5zdWJzbGljZV9tYXNr WzBdID0gQklUKDApIHwgQklUKDEpOwo+Pj4gLQkJc3NldS0+c3Vic2xpY2VfbWFza1sxXSA9IEJJ VCgwKSB8IEJJVCgxKTsKPj4+ICsJCXN1YnNsaWNlX21hc2sgPSBCSVQoMCkgfCBCSVQoMSk7Cj4+ PiAgICAJCWJyZWFrOwo+Pj4gICAgCX0KPj4+ICAgIAo+Pj4gLQlzc2V1LT5tYXhfc2xpY2VzID0g aHdlaWdodDgoc3NldS0+c2xpY2VfbWFzayk7Cj4+PiAtCXNzZXUtPm1heF9zdWJzbGljZXMgPSBo d2VpZ2h0OChzc2V1LT5zdWJzbGljZV9tYXNrWzBdKTsKPj4+IC0KPj4+ICAgIAlmdXNlMSA9IEk5 MTVfUkVBRChIU1dfUEFWUF9GVVNFMSk7Cj4+PiAgICAJc3dpdGNoICgoZnVzZTEgJiBIU1dfRjFf RVVfRElTX01BU0spID4+IEhTV19GMV9FVV9ESVNfU0hJRlQpIHsKPj4+ICAgIAlkZWZhdWx0Ogo+ Pj4gQEAgLTU5OCw5ICs2MTAsMTQgQEAgc3RhdGljIHZvaWQgaGFzd2VsbF9zc2V1X2luZm9faW5p dChzdHJ1Y3QKPj4+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+Pj4gICAgCQlzc2V1LT5l dV9wZXJfc3Vic2xpY2UgPSA2Owo+Pj4gICAgCQlicmVhazsKPj4+ICAgIAl9Cj4+PiAtCXNzZXUt Pm1heF9ldXNfcGVyX3N1YnNsaWNlID0gc3NldS0+ZXVfcGVyX3N1YnNsaWNlOwo+Pj4gKwo+Pj4g KwlpbnRlbF9zc2V1X3NldF9pbmZvKHNzZXUsIGh3ZWlnaHQ4KHNzZXUtPnNsaWNlX21hc2spLAo+ Pj4gKwkJCSAgICBod2VpZ2h0OChzdWJzbGljZV9tYXNrKSwKPj4+ICsJCQkgICAgc3NldS0+ZXVf cGVyX3N1YnNsaWNlKTsKPj4KPj4gSSdkIHN0aWxsIHByZWZlciB0aGlzIHRvIHVzZSBhIGxvY2Fs IHZhcmlhYmxlIHNvIHRoYXQgd2UgYWx3YXlzIG9ubHkKPj4gc2V0Cj4+IHNzZXUtPmV1X3Blcl9z dWJzbGljZSBmcm9tIHdpdGhpbiBpbnRlbF9zc2V1X3NldF9pbmZvLgo+IAo+IFNvIHRoZSByZWFz b24gSSBrZXB0IHRoaXMgaXMgaW4gaW50ZWxfc3NldV9zZXRfaW5mbyB3ZSBhcmUgcmVhbGx5IGp1 c3QKPiBzZXR0aW5nIHRoZSBtYXhfZXVzX3Blcl9zdWJzbGljZSwgbm90IHRoZSBldV9wZXJfc3Vi c2xpY2UuIEFyZSB5b3UKPiBzYXlpbmcgeW91J2QgYWxzbyBsaWtlIHRvIG1vdmUgdGhlIGNvZGUg dGhhdCBzZXRzIGV1X3Blcl9zdWJzbGljZSBpbgo+IGVhY2ggZ2VuZXJhdGlvbidzIGhhbmRsZXIg dG8gbG9jYWwgdmFyaWFibGVzIGFuZC9vciBqdXN0IHBhc3NlZAo+IGRpcmVjdGx5IGFzIGFuIGFy Z3VtZW50IHRvIGludGVsX3NzZXVfc2V0X2luZm8/CgpNeSBiYWQsIEkgY29uZnVzZWQgZXVfcGVy X3N1YnNsaWNlIGFuZCBtYXhfZXVzX3Blcl9zdWJzbGljZSBhcyB0aGUgc2FtZSAKdmFyaWFibGUu IEp1c3QgaWdub3JlIHRoaXMgY29tbWVudCA6KQoKRGFuaWVsZQoKPiAKPiBJLmUuIHNob3VsZCB3 ZSB1c2UgaW50ZWxfc3NldV9zZXRfaW5mbyB0byBzZXQgbW9zdCBvciBhbGwgb2YgdGhlCj4gbWVt YmVycyBvZiB0aGUgaW50ZWxfc3NldSBzdHJ1Y3R1cmU/IE9yIGlzIGl0IE9LIHRvIGtlZXAgdGhl IGN1cnJlbnQKPiBpbXBsZW1lbnRhdGlvbiBvZiBvbmx5IHVzaW5nIHRoaXMgdG8gc2V0IGRlZmF1 bHQgbWF4aW11bXMgcGVyIHBsYXRmb3JtPwo+IAo+IC1TdHVhcnQKPiAKPj4KPj4gRGFuaWVsZQo+ Pgo+Pj4gICAgCj4+PiAgICAJZm9yIChzID0gMDsgcyA8IHNzZXUtPm1heF9zbGljZXM7IHMrKykg ewo+Pj4gKwkJaW50ZWxfc3NldV9zZXRfc3Vic2xpY2VzKHNzZXUsIHMsIHN1YnNsaWNlX21hc2sp Owo+Pj4gKwo+Pj4gICAgCQlmb3IgKHNzID0gMDsgc3MgPCBzc2V1LT5tYXhfc3Vic2xpY2VzOyBz cysrKSB7Cj4+PiAgICAJCQlpbnRlbF9zc2V1X3NldF9ldXMoc3NldSwgcywgc3MsCj4+PiAgICAJ CQkJCSAgICgxVUwgPDwgc3NldS0KPj4+PiBldV9wZXJfc3Vic2xpY2UpIC0gMSk7Cj4+PgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=