From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 04/14] drm/i915: Inline __i915_gem_request_wait_for_execute() Date: Fri, 17 Feb 2017 14:04:16 +0000 Message-ID: <00c64800-afce-e860-0a3e-fceebd9ab117@linux.intel.com> References: <20170214095413.26452-1-chris@chris-wilson.co.uk> <20170214095413.26452-5-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF0906ED20 for ; Fri, 17 Feb 2017 14:04:18 +0000 (UTC) In-Reply-To: <20170214095413.26452-5-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE0LzAyLzIwMTcgMDk6NTQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJdCBoYWQgb25seSBv bmUgY2FsbHNpdGUgYW5kIGV4aXN0ZWQgdG8ga2VlcCB0aGUgY29kZSBjbGVhcmVyLiBOb3cKPiBo YXZpbmcgc2hhcmVkIHRoZSB3YWl0LW9uLWVycm9yIGJldHdlZW4gcGhhc2VzIGFuZCB3aXRoIHBs YW5zIHRvIGNoYW5nZQo+IHRoZSB3YWl0LWZvci1leGVjdXRlIGluIHRoZSBuZXh0IGZldyBwYXRj aGVzLCByZW1vdmUgdGhlIG91dCBvZiBsaW5lCj4gd2FpdCBsb29wIGFuZCBtb3ZlIGl0IGludG8g dGhlIG1haW4gYm9keSBvZiBpOTE1X3dhaXRfcmVxdWVzdC4KPgo+IFNpZ25lZC1vZmYtYnk6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMgfCA3OCArKysrKysrKysrKystLS0tLS0tLS0t LS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDQ5IGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3Jl cXVlc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+IGluZGV4 IGRjYzBhN2FiOTVkYy4uMDAxZmM5ZmVkZjQ5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtX3JlcXVlc3QuYwo+IEBAIC05ODgsNTQgKzk4OCw2IEBAIGJvb2wgX19pOTE1X3NwaW5f cmVxdWVzdChjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiAgCXJldHVy biBmYWxzZTsKPiAgfQo+Cj4gLXN0YXRpYyBsb25nCj4gLV9faTkxNV9yZXF1ZXN0X3dhaXRfZm9y X2V4ZWN1dGUoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0LAo+IC0JCQkJdW5z aWduZWQgaW50IGZsYWdzLAo+IC0JCQkJbG9uZyB0aW1lb3V0KQo+IC17Cj4gLQljb25zdCBpbnQg c3RhdGUgPSBmbGFncyAmIEk5MTVfV0FJVF9JTlRFUlJVUFRJQkxFID8KPiAtCQlUQVNLX0lOVEVS UlVQVElCTEUgOiBUQVNLX1VOSU5URVJSVVBUSUJMRTsKPiAtCXdhaXRfcXVldWVfaGVhZF90ICpx ID0gJnJlcXVlc3QtPmk5MTUtPmdwdV9lcnJvci53YWl0X3F1ZXVlOwo+IC0JREVGSU5FX1dBSVQo cmVzZXQpOwo+IC0JREVGSU5FX1dBSVQod2FpdCk7Cj4gLQo+IC0JaWYgKGZsYWdzICYgSTkxNV9X QUlUX0xPQ0tFRCkKPiAtCQlhZGRfd2FpdF9xdWV1ZShxLCAmcmVzZXQpOwo+IC0KPiAtCWRvIHsK PiAtCQlwcmVwYXJlX3RvX3dhaXQoJnJlcXVlc3QtPmV4ZWN1dGUud2FpdCwgJndhaXQsIHN0YXRl KTsKPiAtCj4gLQkJaWYgKGk5MTVfc3dfZmVuY2VfZG9uZSgmcmVxdWVzdC0+ZXhlY3V0ZSkpCj4g LQkJCWJyZWFrOwo+IC0KPiAtCQlpZiAoZmxhZ3MgJiBJOTE1X1dBSVRfTE9DS0VEICYmCj4gLQkJ ICAgIGk5MTVfcmVzZXRfaW5fcHJvZ3Jlc3MoJnJlcXVlc3QtPmk5MTUtPmdwdV9lcnJvcikpIHsK PiAtCQkJX19zZXRfY3VycmVudF9zdGF0ZShUQVNLX1JVTk5JTkcpOwo+IC0JCQlpOTE1X3Jlc2V0 KHJlcXVlc3QtPmk5MTUpOwo+IC0JCQlyZXNldF93YWl0X3F1ZXVlKHEsICZyZXNldCk7Cj4gLQkJ CWNvbnRpbnVlOwo+IC0JCX0KPiAtCj4gLQkJaWYgKHNpZ25hbF9wZW5kaW5nX3N0YXRlKHN0YXRl LCBjdXJyZW50KSkgewo+IC0JCQl0aW1lb3V0ID0gLUVSRVNUQVJUU1lTOwo+IC0JCQlicmVhazsK PiAtCQl9Cj4gLQo+IC0JCWlmICghdGltZW91dCkgewo+IC0JCQl0aW1lb3V0ID0gLUVUSU1FOwo+ IC0JCQlicmVhazsKPiAtCQl9Cj4gLQo+IC0JCXRpbWVvdXQgPSBpb19zY2hlZHVsZV90aW1lb3V0 KHRpbWVvdXQpOwo+IC0JfSB3aGlsZSAoMSk7Cj4gLQlmaW5pc2hfd2FpdCgmcmVxdWVzdC0+ZXhl Y3V0ZS53YWl0LCAmd2FpdCk7Cj4gLQo+IC0JaWYgKGZsYWdzICYgSTkxNV9XQUlUX0xPQ0tFRCkK PiAtCQlyZW1vdmVfd2FpdF9xdWV1ZShxLCAmcmVzZXQpOwo+IC0KPiAtCXJldHVybiB0aW1lb3V0 Owo+IC19Cj4gLQo+ICAvKioKPiAgICogaTkxNV93YWl0X3JlcXVlc3QgLSB3YWl0IHVudGlsIGV4 ZWN1dGlvbiBvZiByZXF1ZXN0IGhhcyBmaW5pc2hlZAo+ICAgKiBAcmVxOiB0aGUgcmVxdWVzdCB0 byB3YWl0IHVwb24KPiBAQCAtMTA4NSw3ICsxMDM3LDM1IEBAIGxvbmcgaTkxNV93YWl0X3JlcXVl c3Qoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEsCj4gIAkJYWRkX3dhaXRfcXVldWUo ZXJycSwgJnJlc2V0KTsKPgo+ICAJaWYgKCFpOTE1X3N3X2ZlbmNlX2RvbmUoJnJlcS0+ZXhlY3V0 ZSkpIHsKPiAtCQl0aW1lb3V0ID0gX19pOTE1X3JlcXVlc3Rfd2FpdF9mb3JfZXhlY3V0ZShyZXEs IGZsYWdzLCB0aW1lb3V0KTsKPiArCQlERUZJTkVfV0FJVChleGVjKTsKPiArCj4gKwkJZG8gewo+ ICsJCQlwcmVwYXJlX3RvX3dhaXQoJnJlcS0+ZXhlY3V0ZS53YWl0LCAmZXhlYywgc3RhdGUpOwo+ ICsJCQlpZiAoaTkxNV9zd19mZW5jZV9kb25lKCZyZXEtPmV4ZWN1dGUpKQo+ICsJCQkJYnJlYWs7 Cj4gKwo+ICsJCQlpZiAoZmxhZ3MgJiBJOTE1X1dBSVRfTE9DS0VEICYmCj4gKwkJCSAgICBpOTE1 X3Jlc2V0X2luX3Byb2dyZXNzKCZyZXEtPmk5MTUtPmdwdV9lcnJvcikpIHsKPiArCQkJCV9fc2V0 X2N1cnJlbnRfc3RhdGUoVEFTS19SVU5OSU5HKTsKPiArCQkJCWk5MTVfcmVzZXQocmVxLT5pOTE1 KTsKPiArCQkJCXJlc2V0X3dhaXRfcXVldWUoZXJycSwgJnJlc2V0KTsKPiArCQkJCWNvbnRpbnVl Owo+ICsJCQl9Cj4gKwo+ICsJCQlpZiAoc2lnbmFsX3BlbmRpbmdfc3RhdGUoc3RhdGUsIGN1cnJl bnQpKSB7Cj4gKwkJCQl0aW1lb3V0ID0gLUVSRVNUQVJUU1lTOwo+ICsJCQkJYnJlYWs7Cj4gKwkJ CX0KPiArCj4gKwkJCWlmICghdGltZW91dCkgewo+ICsJCQkJdGltZW91dCA9IC1FVElNRTsKPiAr CQkJCWJyZWFrOwo+ICsJCQl9Cj4gKwo+ICsJCQl0aW1lb3V0ID0gaW9fc2NoZWR1bGVfdGltZW91 dCh0aW1lb3V0KTsKPiArCQl9IHdoaWxlICgxKTsKPiArCQlmaW5pc2hfd2FpdCgmcmVxLT5leGVj dXRlLndhaXQsICZleGVjKTsKPiArCj4gIAkJaWYgKHRpbWVvdXQgPCAwKQo+ICAJCQlnb3RvIGNv bXBsZXRlOwo+Cj4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5A aW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK