From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0ED82C43334 for ; Fri, 8 Jul 2022 08:56:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6EAA7112D77; Fri, 8 Jul 2022 08:56:05 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07715112D76; Fri, 8 Jul 2022 08:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657270565; x=1688806565; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=xoIRMoc7m/H4mzgfZ4Ama9uI5xZ/IoArvNaKA9ERL5Y=; b=RxBi56ChqMppE+vZq3wW9vjzXuZJmnQ/MbN6tANHOA5Ru7vrSh4i6kAd 8SsnIywMi5rG0ZhB/pL4T+z7v96uW3EJO5xERPilJ7uW96y9uw/MreEy2 wdWterzzU/W1OLJVyEd81s2KR6tNjVpCuw4JUW3/pp/7cUZFo6wC3P4f3 PTdoF6CUMysm9JXS2g3gQyRFz87VMULIoNZFA7N1wJ4Q0sOOmpa0mTlsY rXD3Hku6Vs94biZtEDzhWQ9eW5ayh1cX/T0xQYd2FtDZUbZ9apuoPKHig ADdDZ7ypBhVpd7Db6Kx6ZnKsNw9cfUPwRZlGkPbk5S9ZlW8vmsEYpDk9R w==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="285362784" X-IronPort-AV: E=Sophos;i="5.92,255,1650956400"; d="scan'208";a="285362784" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 01:56:04 -0700 X-IronPort-AV: E=Sophos;i="5.92,255,1650956400"; d="scan'208";a="568870123" Received: from ahajda-mobl.ger.corp.intel.com (HELO [10.213.16.201]) ([10.213.16.201]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 01:55:57 -0700 Message-ID: <01c7440e-8198-878c-cfb6-b54468b1dca5@intel.com> Date: Fri, 8 Jul 2022 10:55:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Content-Language: en-US To: Dan Carpenter , Zhenyu Wang , Chris Wilson References: From: Andrzej Hajda Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH] drm/i915/gvt: IS_ERR() vs NULL bug in intel_gvt_update_reg_whitelist() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 08.07.2022 10:41, Dan Carpenter wrote: > The shmem_pin_map() function returns NULL, it doesn't return error > pointers. > > Fixes: 97ea656521c8 ("drm/i915/gvt: Parse default state to update reg whitelist") > Signed-off-by: Dan Carpenter Reviewed-by: Andrzej Hajda Regards Andrzej > --- > drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c > index b9eb75a2b400..1c35a41620ae 100644 > --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c > +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c > @@ -3117,9 +3117,9 @@ void intel_gvt_update_reg_whitelist(struct intel_vgpu *vgpu) > continue; > > vaddr = shmem_pin_map(engine->default_state); > - if (IS_ERR(vaddr)) { > - gvt_err("failed to map %s->default state, err:%zd\n", > - engine->name, PTR_ERR(vaddr)); > + if (!vaddr) { > + gvt_err("failed to map %s->default state\n", > + engine->name); > return; > } >